After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 159986 - [PATCH] Videorate doesn't handle seek and doesn't reset when going from PAUSED to READY
[PATCH] Videorate doesn't handle seek and doesn't reset when going from PAUSE...
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins
git master
Other Linux
: Normal blocker
: 0.8.7
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2004-11-30 16:37 UTC by Edward Hervey
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch to make videorate reset when going from PAUSED to READY, handle src SEEK events properly, and forward events at the good time (4.85 KB, patch)
2004-11-30 16:44 UTC, Edward Hervey 		none Details | Review
correct patch (4.85 KB, patch)
2004-12-16 14:20 UTC, Edward Hervey 		none Details | Review
discont and reset handling patch for videorate (4.47 KB, patch)
2004-12-19 12:51 UTC, Edward Hervey 		none Details | Review
Forwards the discont too (4.51 KB, patch)
2004-12-19 12:55 UTC, Edward Hervey 		none Details | Review

Description Edward Hervey 2004-11-30 16:37:50 UTC 
The videorate element doesn't reset itself when going from GST_STATE_PAUSED to
GST_STATE_READY and it doesn't handle GST_EVENT_SEEK.
Comment 1 Edward Hervey 2004-11-30 16:44:34 UTC 
Created attachment 34329 [details] [review]
Patch to make videorate reset when going from PAUSED to READY, handle src SEEK events properly, and forward events at the good time

Patch to solve the problem
Comment 2 Stephane Loeuillet 2004-12-12 14:16:21 UTC 
confirming bug, setting as blocker for first pitivi release, adding PATCH keyword
Comment 3 Ronald Bultje 2004-12-16 11:58:22 UTC 
Is this patch -R or so? It looks totally weird to me.
Comment 4 Edward Hervey 2004-12-16 13:40:53 UTC 
I just noticed, it is :( Do you want a normal version ?
Comment 5 Edward Hervey 2004-12-16 14:20:59 UTC 
Created attachment 34896 [details] [review]
correct patch

Here's the patch made in the correct order.
Comment 6 Ronald Bultje 2004-12-19 12:12:16 UTC 
Repeat of what I said on IRC: don't calculate next timestamps in a SEEK event,
but in a DISCONT event. Seeks are not necessarily exact, and seeks are not
necessarily synchronous. Once that's fixed, I'll apply it.
Comment 7 Edward Hervey 2004-12-19 12:51:12 UTC 
Created attachment 35000 [details] [review]
discont and reset handling patch for videorate

The patch now resets itself with GST_EVENT_DISCONTINUOUS on sinkpad and not
GST_EVENT_SEEK on srcpad.
Comment 8 Edward Hervey 2004-12-19 12:55:44 UTC 
Created attachment 35001 [details] [review]
Forwards the discont too

It works better when I forward the handled discont event :)
Comment 9 Ronald Bultje 2004-12-19 13:16:12 UTC 
Committed, thanks.