After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 159806 - label field should be translated in ui services
label field should be translated in ui services
Status: RESOLVED FIXED
Product: Gnumeric
Classification: Applications
Component: GUI
git master
Other All
: Normal enhancement
: ---
Assigned To: Jody Goldberg
Jody Goldberg
Depends on:
Blocks:
 
 
Reported: 2004-11-29 09:34 UTC by Jean Bréfort
Modified: 2009-09-21 19:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
proposed patch (3.41 KB, patch)
2009-09-19 10:22 UTC, Jean Bréfort
committed Details | Review

Description Jean Bréfort 2004-11-29 09:34:45 UTC
This concerns plugins exporting ui service (python-loader and database AFAIK).
in python-loader/plugin.xml.in:
			<actions>
				<action name="ShowConsole"
				label="Python console"/>	
			</actions>

So label is not marked for translation but is a user visible string.
Comment 1 Andreas J. Guelzow 2009-06-25 00:10:11 UTC
This seems like it should be really easy. Does anybody know how to do this?
Comment 2 Morten Welinder 2009-06-25 02:03:24 UTC
Not that easy in general.  The plugin would need its own translation domain.
(Since out-of-tree plugins can't very well have their translations in
Gnumeric.)
Comment 3 Andreas J. Guelzow 2009-06-25 04:02:22 UTC
Well, I had looked at our po files and saw:

#: ../plugins/python-loader/gnm-py-interpreter.c:255
msgid "Default interpreter"
msgstr "Vorgabeinterpreter"

#: ../plugins/python-loader/gnm-python.c:130
#: ../plugins/python-loader/gnm-python.c:152
#, c-format
msgid "Could not import %s."
msgstr "%s konnte nicht gefunden werden."

#: ../plugins/python-loader/gnm-python.c:137
#, c-format
msgid "Could not find %s."
msgstr "%s konnte nicht gefunden werden."

#: ../plugins/python-loader/gnm-python.c:145
#, c-format
msgid "Could not initialize Python bindings for Gtk+, etc: %s"
msgstr "Python-Bindings für GTK+ usw. konnten nicht initialisiert werden: %s"

#: ../plugins/python-loader/gnm-python.c:159
#, c-format
msgid "Could not find %s"
msgstr "%s konnte nicht gefunden werden"

and many more.

So while you are right that it should have its own translation domain, it seems to me the horses have already left the barn.
Comment 4 Jean Bréfort 2009-06-25 11:14:26 UTC
I think we should add a <domain> node or so to plugin.xml. We need also some mechanism to translate functions documentation from out of tree plugins.
Comment 5 Morten Welinder 2009-06-25 14:20:55 UTC
That would work.  In-tree plugins could then point to Gnumeric's domain,
although for the sake of the example, the ui-hello plugin probably should
not.
Comment 6 Jean Bréfort 2009-09-19 09:46:35 UTC
I tried to mark the ui string for translation. Unfortunately, this does not work. To make things work, we might have the label property become a child node. Is this ok ?
Comment 7 Jean Bréfort 2009-09-19 10:22:52 UTC
Created attachment 143482 [details] [review]
proposed patch
Comment 8 Morten Welinder 2009-09-21 19:16:29 UTC
Comment on attachment 143482 [details] [review]
proposed patch

Go ahead.  If there are
any problems we'll fix them.
Comment 9 Jean Bréfort 2009-09-21 19:47:05 UTC
Fixed.