After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 159786 - Colorbalance list_channels conflicts with tuner list_channels
Colorbalance list_channels conflicts with tuner list_channels
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-python
git master
Other Linux
: Normal normal
: 0.8.0
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2004-11-29 02:09 UTC by Zaheer Abbas Merali
Modified: 2005-06-30 15:35 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Zaheer Abbas Merali 2004-11-29 02:09:53 UTC
Look in interfaces.defs ... as v4lsrc and v4l2src are both colorbalance and
tuners, the list_channels is wrong for colorbalance.  Maybe replace with
list_colorbalance_channels ?

Problem is API breakage...but as list_channels never worked for colorbalance
objects coz all of them tended to have tuners its probably safe to do.
Comment 1 Johan (not receiving bugmail) Dahlin 2004-11-29 09:40:23 UTC
Well, it's possible to do something like:

  gst.interfaces.Tuner.list_channels(self)

and

  gst.interfaces.ColorBalance.list_channels(self)

However, it's quite ugly as you point out and you cannot really be sure which
one to call.

This should in reality be fixed upstream, so all different should use unique
method names to avoid clashes like this.
Comment 2 Zaheer Abbas Merali 2004-11-29 09:45:53 UTC
No API breakage coz that function wasnt exposed anyway due to there being no
override.

A patch to fix this and add fields to colorbalancechannel type is at:

http://zaheer.merali.org/random/interfaces.patch
Comment 3 Zaheer Abbas Merali 2004-11-29 10:19:47 UTC
it cant be fixed upstream in 0.8 cycle due to api breakage
Comment 4 Johan (not receiving bugmail) Dahlin 2004-11-29 12:26:45 UTC
Committed to cvs, thanks