GNOME Bugzilla – Bug 159433
[osssink] doesn't check for supported channels
Last modified: 2004-12-22 21:47:04 UTC
$gst-launch-0.8 sinesrc ! gsmenc ! udpsink $gst-launch-0.8 udpsrc ! gsmdec ! audioconvert ! osssink WARNING **: couldn't set the right number of channels (wanted 1, got 2), enjoy the tone difference Audio is played too slowly, half the frequency. #gsteamer: 14:03 | <BBB> hm, does oss actually check the supported chans on startup?
Created attachment 34797 [details] [review] gstosselement.c - adds functionality to check if device supports mono, stereo or both ChangeLog entry: 2004-12-13 Toni Willberg <toniw@iki.fi> * sys/oss/gstosselement.c: Added functionality to test if the device supports mono, stereo or both. Fixes bug #159433 * sys/oss/oss_probe.c: Added same mono/stereo test. Added missing copyright and license header.
Created attachment 34798 [details] [review] oss_probe.c - checks if device supports mono, stereo or both
if both mono_supported and stereo_supported are FALSE, please be sure to error out (or set channels to the 1,2 range). Don't set it to 0, we'll fail at random places elsewhere and it'll be harder to track... Otherwise, good work.
Created attachment 34799 [details] [review] gstosselement.c - adds functionality to check if device supports mono, stereo or both Added error better error handling; now sets channels [1,2] if the device doesn't seem to support channels at all.
Both applied, thanks for the work!