After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 159304 - Closing a 2nd view of an image toggles the visibility of an active layer
Closing a 2nd view of an image toggles the visibility of an active layer
Status: RESOLVED FIXED
Product: GIMP
Classification: Other
Component: General
git master
Other All
: High trivial
: 2.4
Assigned To: GIMP Bugs
GIMP Bugs
: 161458 166753 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2004-11-24 13:21 UTC by Jakub Steiner
Modified: 2005-02-09 09:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Jakub Steiner 2004-11-24 13:21:57 UTC 
To reproduce:

1. open or create an image with layers
2. create a new view of it
3. select the top layer
4. close the view
5. notice the top layer's visibility has been toggled to off
Comment 1 Sven Neumann 2004-11-24 13:48:56 UTC 
I can definitely not reproduce this.
Comment 2 Sven Neumann 2004-11-24 13:49:57 UTC 
Hmm, tried once more and this time it happened. This is strange indeed.
Comment 3 Michael Natterer 2004-11-24 16:42:17 UTC 
Fixed in CVS:

2004-11-24  Michael Natterer  <mitch@gimp.org>

	* app/gui/gui.c (gui_display_changed): if the active display
	becomes NULL (e.g. by closing a view), don't leave the user
	context with an image but no display. Instead, try to find another
	display of the same image instead and if that fails set the image
	to NULL.

	Prevents the various foo_actions_update() functions from being
	called with a NULL display while there is still an active image in
	the context.

	Fixes bug #159304.

	(Removed #warning about being misplaced from that function because
	it's a typical piece of ugly glue code that belongs exactly here).
Comment 4 Sven Neumann 2004-12-16 17:32:02 UTC 
*** Bug 161458 has been marked as a duplicate of this bug. ***
Comment 5 Michael Natterer 2005-02-04 14:40:20 UTC 
Reopening because the addition of the <Toolbox> UI manager brought
back this bug with exactly the same reasons & symptoms.
Comment 6 Michael Natterer 2005-02-08 17:58:53 UTC 
Fixed again in CVS:

2005-02-08  Michael Natterer  <mitch@gimp.org>

	* app/gui/gui.c (gui_display_changed): if display became NULL
	(e.g. by closing a view) and we decide to activate another view
	of the same image, stop the emission of the original
	"display-changed" signal so it doesn't affect the toolbox'
	UI manager. Fixes bug #159304.
Comment 7 Michael Natterer 2005-02-09 09:47:56 UTC 
*** Bug 166753 has been marked as a duplicate of this bug. ***