After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 159216 - Make the label on the capplet have selectable text
Make the label on the capplet have selectable text
Status: RESOLVED FIXED
Product: vino
Classification: Applications
Component: Preferences Dialog
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Vino Maintainer(s)
Vino Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2004-11-23 16:47 UTC by Mariano Suárez-Alvarez
Modified: 2006-10-27 08:36 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Use GtkLinkButton instead of VinoURL (4.28 KB, patch)
2006-10-11 07:34 UTC, Mariano Suárez-Alvarez 		committed Details | Review

Description Mariano Suárez-Alvarez 2004-11-23 16:47:23 UTC 
So that one can cut and paste the command to be used to connect to vino.
Comment 1 Mark McLoughlin 2005-05-16 13:35:45 UTC 
Not as straightforward as it might seem because of the way VinoURL overrides the
GtkLabel button_press handler
Comment 2 Mariano Suárez-Alvarez 2006-10-11 07:34:01 UTC 
Created attachment 74466 [details] [review]
Use GtkLinkButton instead of VinoURL

This patch uses GtkLinkButton instead of VinoURL in the capplet. This does not make the text selectable, but gives the button a context menu which has a Copy operation. 

The button could be made GTK_RELIEF_NONE or made not to get centered. IMO it is better to leave things as they are.

The patch does not remove the vino-url.{c,h} files, of course...
Comment 3 Mark McLoughlin 2006-10-27 08:36:29 UTC 
As you say, it's not perfect 'cause:

  - The label still isn't selectable

  - What you get when you "Copy URL" is the full "mailto" URL rather than
    the command

Still, better than it was. Thanks

2006-10-27  Mark McLoughlin  <mark@skynet.ie>

        Use GtkLinkButton instead of VinoURL.

        Patch from Mariano Suárez-Alvarez <mariano.suarezalvarez@gmail.com>
        in bug #159216.

        * vino/configure.in: require gtk+ 2.10

        * vino/capplet/vino-preferences.c: use GtkLinkButton

        * vino/capplet/vino-url.[ch]: remove

        * vino/capplet/Makefile.am: remove vino-url.[ch]