GNOME Bugzilla – Bug 159215
[PATCH] Memory leaks in audioscale
Last modified: 2004-12-22 21:47:04 UTC
audioscale leaks a lot because of libresample. Here'a a valgrind log (running a pipeline twice): ==20423== 5952 bytes in 2 blocks are possibly lost in loss record 22 of 28 ==20423== at 0x1B9069FF: realloc (vg_replace_malloc.c:197) ==20423== by 0x1C12C374: gst_resample_sinc_ft_s16 (resample.c:498) ==20423== by 0x1C12B90D: gst_resample_scale (resample.c:211) ==20423== by 0x1C1257D6: gst_audioscale_chain (gstaudioscale.c:656) ==20423== ==20423== ==20423== 9216 bytes in 2 blocks are definitely lost in loss record 23 of 28 ==20423== at 0x1B905EDD: malloc (vg_replace_malloc.c:131) ==20423== by 0x1C12B7E3: gst_resample_scale (resample.c:187) ==20423== by 0x1C1257D6: gst_audioscale_chain (gstaudioscale.c:656) ==20423== by 0x1B94BF63: gst_pad_call_chain_function (gstpad.c:4402)
I added the following code to resample.c void gst_resample_close (gst_resample_t * r) { if (r->buffer) { free (r->buffer); r->buffer = NULL; r->buffer_len = 0; } if (r->hack_union.s.out_tmp) { free (r->hack_union.s.out_tmp); r->hack_union.s.out_tmp = NULL; r->hack_union.s.out_tmp_len = 0; } } Calling this function from audioscale's dispose method gets rid of the memory leaks.
Sebastien, can you attach that as a patch? Thanks.
Created attachment 34726 [details] [review] leak fix Adds function gst_resample_close() to libresample which is called in audioscale's dispose(). The patch has been created and tested with gst-plugins-0.8.5 but it applies correctly against gst-plugins-0.8.6.
Setting milestone on this so that thomas or ronald will be sure to review it before next release
Applied to CVS, thanks.