After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 159119 - use libcpufreq from cpufrequtils in cpufreq applet
use libcpufreq from cpufrequtils in cpufreq applet
Status: RESOLVED FIXED
Product: gnome-applets
Classification: Other
Component: cpufreq
git master
Other Linux
: Normal enhancement
: 2.12
Assigned To: gnome-applets Maintainers
gnome-applets Maintainers
Depends on:
Blocks:
 
 
Reported: 2004-11-22 21:29 UTC by Dominik Brodowski
Modified: 2010-01-24 01:07 UTC
See Also:
GNOME target: ---
GNOME version: Unversioned Enhancement


Attachments
an example patch for gnome-cpufreq-applet-0.3.1 (9.89 KB, patch)
2004-11-22 21:32 UTC, Dominik Brodowski
none Details | Review

Description Dominik Brodowski 2004-11-22 21:29:29 UTC
The new cpufrequtils package (temporary(!) home at http://www.brodo.de/cpufreq/
, latest revision http://www.brodo.de/cpufreq/cpufrequtils-0.1-pre3.tar.bz2 )
includes a libcpufreq library which allows all sorts of cpufreq userspace tools
to _not_ worry about using /proc/ or /sys/ files to access information about
cpufreq or to set a new CPU frequency. It allows for a shared code base, and
much smaller individual tools -- like the former gnome-cpufreq-applet.
Comment 1 Dominik Brodowski 2004-11-22 21:32:50 UTC
Created attachment 34039 [details] [review]
an example patch for gnome-cpufreq-applet-0.3.1

The example patch shows how few code is needed for cpufreq information
retrieval / setting if cpufrequtils/libcpufreq is used. If native access to
/proc and /sys is dropped, much code can be removed as well as the whole
cpufreq-select directory, as that tool is superseded by "cpufreq-set" from
cpufrequtils.
Comment 2 Danielle Madeley 2005-01-09 09:01:22 UTC
Do we want external dependancies for this?
Comment 3 Carlos Garcia Campos 2005-01-10 17:10:05 UTC
With the new code design, we can do it without adding a dependency. We can
simply look for libcpufreq in the configure script and create a Monitor based on
libcpufreq in run time. If libcpufreq is not detected we'll create a Monitor
based on proc, sys, etc. We only have to write a new CPUFreqMonitor, we don't
even need to change any line of the applet code. 
I think we can mark this bug for 2.12
Comment 4 Danielle Madeley 2005-01-10 17:22:47 UTC
We can do that.
Comment 5 Carlos Garcia Campos 2005-06-27 12:23:07 UTC
Is libcpufreq included in any distribution yet? 
Comment 6 Dominik Brodowski 2005-06-27 12:26:56 UTC
It's included in debian (3.1) and gentoo, at least.
Comment 7 Carlos Garcia Campos 2005-06-27 13:49:38 UTC
Good news! I'm going to work on it this summer. 
Comment 8 Danielle Madeley 2005-12-21 05:17:27 UTC
Carlos, ping?
Comment 9 Carlos Garcia Campos 2005-12-21 10:09:37 UTC
Sorry, I've been really busy in the current release cycle, but I haven't forgotten this bug :-P I'll try to work on it ASAP.
Comment 10 Carlos Garcia Campos 2006-06-17 19:31:11 UTC
hey Dominik!

finally I've added support for libcpufreq in both the applet and the selector. Sorry for the really long delay. Better late than never ...

Thanks for that great library! :-)