After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 158442 - Festival doesn't have speech markers
Festival doesn't have speech markers
Status: RESOLVED FIXED
Product: gnome-speech
Classification: Deprecated
Component: drivers
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME Speech Maintainer(s)
GNOME Speech Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2004-11-16 11:17 UTC by Oana Serb
Modified: 2005-01-11 10:42 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed patch (37.46 KB, patch)
2004-11-16 11:22 UTC, Oana Serb 		none Details | Review
A better patch (39.17 KB, patch)
2004-11-22 17:03 UTC, Oana Serb 		none Details | Review
Proposed patch (40.21 KB, patch)
2004-11-24 10:50 UTC, Oana Serb 		none Details | Review
Proposed patch (42.80 KB, patch)
2004-12-06 17:12 UTC, Oana Serb 		none Details | Review
Proposed patch (28.55 KB, patch)
2004-12-08 09:16 UTC, Oana Serb 		none Details | Review
Proposed patch (29.46 KB, patch)
2005-01-10 15:29 UTC, Oana Serb 		committed Details | Review

Description Oana Serb 2004-11-16 11:17:33 UTC 
In the current implementation, Festival doesn't have speech markers.
Comment 1 Oana Serb 2004-11-16 11:22:56 UTC 
Created attachment 33832 [details] [review]
Proposed patch
Comment 2 Oana Serb 2004-11-22 17:03:43 UTC 
Created attachment 34032 [details] [review]
A better patch
Comment 3 Oana Serb 2004-11-24 10:44:08 UTC 
Comment on attachment 34032 [details] [review]
A better patch

It's not the wanted patch
Comment 4 Oana Serb 2004-11-24 10:50:09 UTC 
Created attachment 34084 [details] [review]
Proposed patch
Comment 5 Oana Serb 2004-12-06 17:12:51 UTC 
Created attachment 34554 [details] [review]
Proposed patch

The functionality of this patch is the same as previous.
This patch is using a list of callbacks for the speaker.
This patch doesn't remove the old callback member from 'Speaker' structure
because the intention is not to break the building of other drivers.
Comment 6 Oana Serb 2004-12-08 09:16:06 UTC 
Created attachment 34624 [details] [review]
Proposed patch

This is the wanted patch.
Comment 7 Oana Serb 2005-01-10 15:29:16 UTC 
Created attachment 35787 [details] [review]
Proposed patch

The callbacks list is not process in an idle anymore.
Comment 8 bill.haneman 2005-01-11 10:42:17 UTC 
Thanks for the commit Oana.  I am adding this comment to confirm the verbal
approval for the commit which I gave yesterday.