After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 158319 - Does not build out of src dir
Does not build out of src dir
Status: RESOLVED FIXED
Product: gnome-terminal
Classification: Core
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: GNOME Terminal Maintainers
GNOME Terminal Maintainers
Depends on:
Blocks:
 
 
Reported: 2004-11-15 01:18 UTC by Marco Pesenti Gritti
Modified: 2006-01-12 16:44 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Use buildir for gnome-terminal.schemas (732 bytes, patch)
2005-09-19 10:19 UTC, Marco Pesenti Gritti
committed Details | Review

Description Marco Pesenti Gritti 2004-11-15 01:18:49 UTC
It fails to install gnome-terminal.schemas
Comment 1 Mariano Suárez-Alvarez 2004-11-15 08:28:41 UTC
This should be FIXED in HEAD now.
Comment 2 Marco Pesenti Gritti 2004-12-13 21:06:05 UTC
It looks like this was reverted by the another commit, without any comment about
it in the changelog. Mistake?
Comment 3 Mariano Suárez-Alvarez 2004-12-16 05:34:39 UTC
It stopped distchecking, and I needed to do a release. I thought I had added a
changelog entry, though... hrm.

Let's see. 

$(schema_DATA) is gnome-terminal.schemas, which is generated at dist time, so it
is in the source directory, and the command to install schemas currently reads:

  GCONF_CONFIG_SOURCE=$(GCONF_SCHEMA_CONFIG_SOURCE) $(GCONFTOOL)
--makefile-install-rule $(srcdir)/$(schema_DATA)

which looks sane to me. Before the reversion, it used
$(top_builddir)/src/$(schema_DATA) instead, which failed during distcheck
because gnome-terminal.schemas is not in the build dir. 

The current situation seems the correct one to me: I guess I am missing something?
Comment 4 Marco Pesenti Gritti 2004-12-17 10:24:58 UTC
Hmm gnome-terminal seem to distribute schemas differently than other gnome apps.
Generally the .in file is distributed and the schemas generated from it.
gnome-terminal distributes the schemas file directly. Any reason for that?
Comment 5 Kjartan Maraas 2005-08-19 19:49:04 UTC
It seems like the .in file is distributed here just like in every other module.
What makes you think it's not? EXTRA_DIST has $(schemas_in_files) and no mention
of the .schemas file at all.
Comment 6 Kjartan Maraas 2005-09-19 08:55:43 UTC
Marco? Ping?
Comment 7 Marco Pesenti Gritti 2005-09-19 10:18:02 UTC
I dont remember the reason of my comment, it's passed a lot of time. Anyway
probably something is changed because using top_buildir now seem to work fine
for distcheck too. Attaching patch...
Comment 8 Marco Pesenti Gritti 2005-09-19 10:19:00 UTC
Created attachment 52386 [details] [review]
Use buildir for gnome-terminal.schemas
Comment 9 Guilherme de Siqueira Pastore 2006-01-12 16:42:36 UTC
The patch doesn't apply. Is the problem gone? Can this be closed?
Comment 10 Guilherme de Siqueira Pastore 2006-01-12 16:44:29 UTC
Uh, sorry, my stupid mistake. It does apply and has been applied. Thanks.