Bug 158126 – Crashes opening an empty XLS file

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 158126 - Crashes opening an empty XLS file


Summary:	Crashes opening an empty XLS file


Status:	RESOLVED FIXED

Product:	Gnumeric
Classification:	Applications
Component:	General
Version:	git master
Hardware:	Other All

Importance:	Normal normal
Target Milestone:	---
Assigned To:	Jody Goldberg
QA Contact:	Jody Goldberg

URL:
Whiteboard:

Depends on:
Blocks:

Reported:	2004-11-12 23:59 UTC by Germán Poo-Caamaño
Modified:	2004-12-22 21:47 UTC

See Also:
GNOME target:	---
GNOME version:	---

Description Germán Poo-Caamaño 2004-11-12 23:59:55 UTC

$ touch foo.xls
$ gnumeric foo.xls


Backtrace was generated from '/usr/bin/gnumeric'

(no debugging symbols found)...Using host libthread_db library
"/lib/tls/libthread_db.so.1".
(no debugging symbols found)...(no debugging symbols found)...(no debugging
symbols found)...[Thread debugging using libthread_db enabled]
[New Thread -1223918848 (LWP 13278)]
0xb771840e in __waitpid_nocancel () from /lib/tls/libpthread.so.0

+ Trace 51905

#0 __waitpid_nocancel
from /lib/tls/libpthread.so.0
#1 libgnomeui_segv_handle
at gnome-ui-init.c line 741
#2 <signal handler called>
#3 lotus_file_probe
from /usr/lib/gnumeric/1.3.93/plugins/lotus/lotus.so
#4 ??
#5 ??
#6 ??
#7 ??
#8 ??
#9 ??
#10 gnumeric_point_sizes
#11 ??
#12 ??
#13 ??
#14 gnm_plugin_loader_module_get_type

Comment 1 Andreas J. Guelzow 2004-11-13 01:42:08 UTC

I am not used to that libgsf stuff, but it seems to me that in
plugins/lotus-123/boot.c in the function lotus_file_probe
the code

	if (h == NULL &&
	    GSF_LE_GET_GUINT16 (h+0) != LOTUS_BOF)
		return FALSE;
 should be:

	if (h == NULL ||
	    GSF_LE_GET_GUINT16 (h+0) != LOTUS_BOF)
		return FALSE;

Comment 2 Morten Welinder 2004-11-13 01:52:11 UTC

Agreed.  Please commit.

Comment 3 Andreas J. Guelzow 2004-11-13 03:44:47 UTC

fixed in cvs head