After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 157986 - [vorbisdec] fix warning when querying while draining
[vorbisdec] fix warning when querying while draining
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins
git master
Other Linux
: Normal normal
: 0.8.6
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2004-11-11 19:33 UTC by Tim-Philipp Müller
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch (677 bytes, patch)
2004-11-11 19:35 UTC, Tim-Philipp Müller
none Details | Review

Description Tim-Philipp Müller 2004-11-11 19:33:37 UTC
I occasionally get GST_IS_PAD() assertion failure warnings when querying my 
pipeline's audiosink. These are caused by vorbisdec calling gst_pad_query() on 
its sinkpad while the sinkpad is NULL. 
 
Patch attached. 
 
Cheers  
 -Tim 
 
Nov 11 15:51:55 <__tim> hmm, I'm getting GST_IS_PAD() failures in the call 
from vorbisdec.c, 248 occasionally when querying the audiosink 
Nov 11 15:52:47 <BBB> __tim, yeah, that's when we're draining 
Nov 11 15:52:57 <__tim> dec->sinkpad is NULL in that case.  So maybe it should 
be   if (!dec->sinkpad || !gst_pad_query()) ? 
Nov 11 15:53:34 <BBB> __tim, feel free to provide a patch that removes the 
warnings 
Nov 11 15:53:49 <BBB> because the query failures are not bad 
Nov 11 15:54:10 <__tim> well, if it's something known that needs fixing, then 
it's better to leave it there 
Nov 11 15:55:57 <BBB> __tim, it doesn't need fixing 
Nov 11 15:56:05 <BBB> __tim, or, rather, apart from the warning 
Nov 11 15:56:10 <BBB> it's just chain transition
Comment 1 Tim-Philipp Müller 2004-11-11 19:35:15 UTC
Created attachment 33692 [details] [review]
patch
Comment 2 Ronald Bultje 2004-11-11 21:19:28 UTC
Thanks you, applied.