GNOME Bugzilla – Bug 157899
Display of burningspeed
Last modified: 2006-01-17 02:44:07 UTC
Hi I think the drive speed listing in nautilus-cd-burner is a bit bad. If I don't whant tp burn at maximum speed i get to choose from a list with all the speeds from 1-48x even though the burner only suppports CD speeds x=2^n. And x=1*n for DVD. It should only show these pure speeds. Other information: I've browsed the cvs and came over this piece of code in nautilus-cd-burner.c: gtk_menu_shell_append (GTK_MENU_SHELL (menu), item); for (i = 1; i <= rec->max_speed_write; i++) { name = g_strdup_printf ("%dx", i); item = gtk_menu_item_new_with_label (name); g_object_set_data (G_OBJECT (item), "speed", GINT_TO_POINTER (i)); gtk_widget_show (item); gtk_menu_shell_append (GTK_MENU_SHELL (menu), item); g_free (name); if I run cdrecord -prcap, I get: Write speed # 0: 8467 kB/s CLV/PCAV (CD 48x, DVD 6x) Write speed # 1: 7056 kB/s CLV/PCAV (CD 40x, DVD 5x) Write speed # 2: 5645 kB/s CLV/PCAV (CD 32x, DVD 4x) Write speed # 3: 4234 kB/s CLV/PCAV (CD 24x, DVD 3x) Write speed # 4: 2822 kB/s CLV/PCAV (CD 16x, DVD 2x) Write speed # 5: 1411 kB/s CLV/PCAV (CD 8x, DVD 1x) so isn't it possible to do a pipe from that? I see the problem to detect if a DVD or a CD i in the tray, a way is to display the above list with both speeds. thats all. Thanx /Daniel
Daniel, thanks for requesting this feature addition. I'm changing the severity to enhancement and confirming this report. You might also want to keep an eye on bug 152428. It is where you'll find discussions about the DVD vs CD burning speeds.
*** Bug 171487 has been marked as a duplicate of this bug. ***
Created attachment 57264 [details] [review] patch implementing the requested functionality (with some help from hal) I've posted a patch to the HAL list that causes HAL to provide this information. It hasn't appeared on the archive page yet but it should appear there soon: http://lists.freedesktop.org/archives/hal/2006-January/thread.html I've also written a patch for nautilus-cd-burner to use this functionality. If you don't use HAL for obtaining hardware information then the behaviour is the same as before (except that the burn speeds are now in a more intuative descending order). More information is in the ChangeLog of the attached patch. Cheers.
It looks like the encoding of the file got messed up on upload. My version is clean.
http://lists.freedesktop.org/archives/hal/2006-January/004261.html
Created attachment 57509 [details] [review] new api HAL 0.5.6 just shipped with my patch included. The API has changed slightly (list of strings instead of a comma-separated list inside a single string). This is an updated patch to account for that change.
Really nice work. I've committed this to HEAD with a few minor changes. The write_speeds should be stored in the private data, few brace style inconsistencies, bumped the HAL requirement, and added the information to list_cddrives. Thanks for doing this! After this I think one of the only other missing features in HAL is: https://bugs.freedesktop.org/show_bug.cgi?id=2233