GNOME Bugzilla – Bug 157650
nautilus should open a password dialog for smbfs mounts
Last modified: 2005-11-22 14:35:10 UTC
Create an fstab entry to mount an SMB share. Do not put the password in fstab. e.g. //myserver/myshare /mnt/smb-share smbfs username=fdetienn/GROUP,noauto,users,rw 0 0 Ask nautilus to mount smb-share (from the Computer folder on the desktop) Nautilus will try to mount the filesystem but will never prompt for a password. When using the "mount" shell command, the password is asked for at mount time.
thanks for the bug. That still happens with the current version.
This also applies to encrypted mounts. IMO, gnome-vfs should prompt for a password for any of these. Will look into a solution.
Created attachment 50415 [details] Sample dialog. I've modified gnome-vfs so that when the 'mount' executable prints 'Password: ' on its TTY and then waits for input, a gnome-vfs-authentication dialog is put up. Will upload a patch in a bit.
Created attachment 50425 [details] [review] Rough patch which prompts for password. Here's a rough patch which prompts for a password when the underlying 'mount' process asks for a password. Needs some more love before it's ready.
Created attachment 50431 [details] [review] Now without nasty deadlocking TODO: - Check for openpty and relevant library properly in configure.in - Allow saving of password in gnome-keyring - Fix problem with unmounting.
I get this strange error when trying to unmount the '/test' mount point through nautilus: Error: mount point /test is not below /media/ This comes from the 'mount' command. Weird. From a terminal (user, non-root) the unmount works fine with: umount /test Very strange.
Created attachment 50551 [details] [review] Updated patch Fixes the umount issue, tries to do saving of passwords.
Created attachment 51535 [details] [review] Polished patch
Some coments in: http://mail.gnome.org/archives/gnome-vfs-list/2005-October/msg00015.html
Created attachment 54799 [details] [review] Patch with Alex's suggested changes - Removed save password support (alex's concerns are valid and difficult to fix reliably). - Don't show loopback drives in 'Computer' - Use PTY code already present in gnome-vfs (was used for sftp-method).
commited.