GNOME Bugzilla – Bug 157384
SAVE / CREATE_FOLDER modes for GtkFileChooserButton
Last modified: 2013-07-10 18:52:54 UTC
(Based on a discussion with Seth, Jonathan) I think we shouldn't allow these modes in 2.6. For Save: * Without paths, you just have 'a name' with no indication of where the file is going to end up. * With paths, you have paths (upsetting certain people), and you get a unhelpfully trunctated path in many cases. * There's a significantly better way to set up selecting a filename to save in: [ Entry ] in [ Folder ] or possibly: [ Entry ] in ‘Folder’ [ ] This combination can't really be a single widget, because it wouldn't give enough packing flexibility. SO, I think we should just encourage people to use an entry plus ChooserButton in select mode. For Create Folder, it's an extremely rare operation, and most of the same considerations apply as above We could add something here later, if we figure out a good way to go, but I think maximum future flexiblity is if we make these g_warning() and fall back to Open mode for 2.6.
Created attachment 33475 [details] [review] a patch Here is a patch to cripple the button.
Committed.
So now, for people who upgraded their gtk2, applications that are using the GTK_FILE_CHOOSER_ACTION_SAVE get a nice warning on stderr, and are only allowed to select an existing file for overwrite. I really fail to see how this is an improvement. Any idea how to fix all the applications that got broken? I suppose a plain text input is better for now. I cannot afford to spend hours/days to migrate (rewrite) my .glade to .ui right now, as gtk-builder-convert fails for half the files.