After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 157267 - _vte_terminal_fudge_pango_colors() breaks Japanese input style
_vte_terminal_fudge_pango_colors() breaks Japanese input style
Status: RESOLVED FIXED
Product: vte
Classification: Core
Component: general
0.11.x
Other Linux
: Normal normal
: ---
Assigned To: Chris Wilson
Nalin Dahyabhai
Depends on:
Blocks:
 
 
Reported: 2004-11-03 18:27 UTC by ynakai
Modified: 2007-01-26 22:44 UTC
See Also:
GNOME target: ---
GNOME version: 2.9/2.10

Attachments
Patch for vte.c - calculate correctly reverse area by each cell (2.12 KB, patch)
2004-11-06 18:46 UTC, ynakai 		none Details | Review

Description ynakai 2004-11-03 18:27:24 UTC 
_vte_terminal_fudge_pango_color() in vte.c breaks
Japanese input style. It uses PANGO_ATTR_UNDERLINE for
preedit string, but this evil function reverse whole text
and void the underline. It really breaks sane Japanese
kana-kanji conversion!

I deleted the  _vte_terminal_fudge_pango_colors()  funcion,
and it works fine.
Comment 1 ynakai 2004-11-06 18:46:34 UTC 
Created attachment 33499 [details] [review]
Patch for vte.c - calculate correctly reverse area by each cell
Comment 2 Michele Baldessari 2005-06-09 23:14:24 UTC 
Hi Yukihiro,

given that the vte maintainer is currently MIA,
maybe you could ask the current maintainer of the vte rpm at Red Hat (whomever
it is currently), to include it in rawhide for a bit of testing from a wider
audience?
Comment 3 Chris Wilson 2007-01-26 22:44:51 UTC 
r1553: 2007-01-26  Chris Wilson  <chris@chris-wilson.co.uk>

	Bug 157267 – _vte_terminal_fudge_pango_colors() breaks Japanese input style

	* src/vte.c: (_vte_terminal_fudge_pango_colors):
		Check the attributes for each cell rather than assuming the
		pango attributes (and cell attributes) are the same for the
		whole string.