Created attachment 33341 [details] [review]
patch to fix warnings reported by sparse

 /* static variables for segfault handling of plugin loading */
 static char *_gst_plugin_fault_handler_filename = NULL;
-extern gboolean *_gst_disable_segtrap;  /* see gst.c */
+extern gboolean _gst_disable_segtrap;  /* see gst.c */
 
 #ifndef HAVE_WIN32
-static gboolean *_gst_plugin_fault_handler_is_setup = FALSE;
+static gboolean _gst_plugin_fault_handler_is_setup = FALSE;
 #endif

those two scare me. The rest all looks fine, they're cosmetic and don't change
anything.

patch commited to CVS

Did you look at _gst_disable_segtrap in gst.c? It's declared as
gboolean _gst_disable_segtrap = FALSE; there so why is it a pointer to a
gboolean here? Doesn't look right in the _gst_plugin_fault_handler_is_setup case
either...

Ah, OK. Yes, Wim committed it correctly. Let's close this.