After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 157123 - drops on widgets inside a GtkSocket/GtkPlug broken
drops on widgets inside a GtkSocket/GtkPlug broken
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: Other
2.5.x
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2004-11-02 10:58 UTC by James Henstridge
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: 2.9/2.10

Attachments
plugapp.c (1.42 KB, text/plain)
2004-11-02 10:59 UTC, James Henstridge 		  Details
socketapp.c (1.88 KB, text/plain)
2004-11-02 11:01 UTC, James Henstridge 		  Details
Here is a patch (1.30 KB, patch)
2004-11-02 18:51 UTC, Matthias Clasen 		none Details | Review

Description James Henstridge 2004-11-02 10:58:49 UTC 
It seems that drops on widgets inside a GtkSocket/GtkPlug don't work with the
HEAD CVS.  Among other things, this breaks DnD to panel applets.

I'll attach a minimal test case to the bug report.

Simply compile the plugapp.c and socketapp.c programs in the same directory and
run socketapp (which will run plugapp).  Then try dragging a file from Nautilus
to each of the buttons.

With GTK 2.4, both buttons act as drag destinations.  With CVS HEAD, only the
button outside of the plug acts as a drag destination.
Comment 1 James Henstridge 2004-11-02 10:59:54 UTC 
Created attachment 33336 [details]
plugapp.c
Comment 2 James Henstridge 2004-11-02 11:01:07 UTC 
Created attachment 33338 [details]
socketapp.c
Comment 3 Matthias Clasen 2004-11-02 18:51:50 UTC 
Created attachment 33352 [details] [review]
Here is a patch
Comment 4 James Henstridge 2004-11-03 02:44:03 UTC 
I just applied this patch here, and it fixes the DnD problem for the test
program attached to this bug, and also for applets on the panel.
Comment 5 Matthias Clasen 2004-11-03 17:06:53 UTC 
2004-11-03  Matthias Clasen  <mclasen@redhat.com>

	* gdk/x11/gdkdnd-x11.c (gdk_drag_motion): Handle the 
	case that the protocol version in the context is not 
	set yet.  (#157123, James Henstridge)