Bug 156967 – title of vnc session is 'LibVNCServer'

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 156967 - title of vnc session is 'LibVNCServer'


Summary:	title of vnc session is 'LibVNCServer'


Status:	RESOLVED FIXED

Product:	vino
Classification:	Applications
Component:	Server
Version:	unspecified
Hardware:	Other Linux

Importance:	Normal minor
Target Milestone:	---
Assigned To:	Vino Maintainer(s)
QA Contact:	Vino Maintainer(s)

URL:
Whiteboard:

Depends on:
Blocks:

Reported:	2004-10-31 15:30 UTC by Luis Villa
Modified:	2006-11-30 17:56 UTC

See Also:
GNOME target:	---
GNOME version:	2.7/2.8

Attachments
Proposed patch (1.59 KB, patch) 2006-11-27 15:45 UTC, Jonh Wendell	none	Details \| Review
vino-set-desktop-name.patch (4.56 KB, patch) 2006-11-30 17:56 UTC, Mark McLoughlin	committed	Details \| Review

Description Luis Villa 2004-10-31 15:30:02 UTC

When using vncviewer+vino, I get a window title called 'TightVNC: LibVNCServer'.
When I was using vncserver directly, I'd get something like 'TightVNC:
$USERNAME'. Seems like vino should set the title to be something like 'TightVNC:
$USERNAME@$HOSTNAME' or something like that.

Comment 1 Daniel Holbach 2006-09-29 13:56:27 UTC

https://launchpad.net/distros/ubuntu/+source/vino/+bug/43051 is about the same bug.

Comment 2 Jonh Wendell 2006-11-27 15:45:42 UTC

Created attachment 77218 [details] [review]
Proposed patch

Hi. Here is the [small] proposed patch. The name gets now username@machine.

A doubt in rfb.h: Why rfbScreen->desktopName is 'const char *' and not just 'char *' ?

Comment 3 Mark McLoughlin 2006-11-30 17:56:18 UTC

Thanks John

I've attached what I committed:

2006-11-30  Mark McLoughlin  <mark@skynet.ie>

        Based on patch from John Wendell <wendell_listas@bani.com.br>
        in bug #156967.

        * server/libvncserver/main.c:
        (rfbGetScreen): strdup the default desktop name.
        (rfbSetDesktopName): add new function.
        (rfbScreenCleanup): free the desktop name
        
        * server/libvncserver/rfb/rfb.h: make desktopName not const
        and add rfbSetDesktopName()
        
        * server/vino-server.c: (vino_server_init_from_screen): set the
        desktop name here to user@host

Comment 4 Mark McLoughlin 2006-11-30 17:56:58 UTC

Created attachment 77434 [details] [review]
vino-set-desktop-name.patch