After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 156761 - changes to XCF file not saved after export
changes to XCF file not saved after export
Status: RESOLVED NOTABUG
Product: GIMP
Classification: Other
Component: User Interface
2.0.x
Other Linux
: Normal normal
: ---
Assigned To: GIMP Bugs
GIMP Bugs
Depends on:
Blocks:
 
 
Reported: 2004-10-28 22:19 UTC by karim nassar
Modified: 2004-10-29 15:30 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description karim nassar 2004-10-28 22:19:09 UTC
* Open XCF
* Make a change
* file->save as
* make it a png
* click 'export' on resulting dialog
* click close on image window
* re-open XCF
* Changes to original not reflected.

I expected that my changes would be made to the XCF. I understand that this fact
is a feature, as I have now created a new file 'img.png' which I am now editing.
However, I would expect a dialog saying 'changes to exported image not reflected
in original file' and an option to make that happen
Comment 1 Michael Schumacher 2004-10-28 22:45:14 UTC
If "Export" would behave like "Save copy as", the changes wouldn't be lost.
Comment 2 karim nassar 2004-10-28 22:47:31 UTC
I just realized that perhaps that was a little unclear...

I know that the dialog says 'exporting won't change the original', but the
original window goes away. I would have to 'save as' xcf again. I guess what
would be better is that the original window is still open and the new image gets
it's own.
Comment 3 Sven Neumann 2004-10-28 23:03:14 UTC
That's exactly what "Save a Copy" is for.
Comment 4 karim nassar 2004-10-28 23:13:30 UTC
Sven, I understand what save copy as is. That is not the point. Due to an
unclear interface, I lost data. When I closed the exported copy, I thought my
XCF would still be around.
Comment 5 Sven Neumann 2004-10-28 23:19:01 UTC
Errr, well, you misinterpreted the user interface then. Saving a document means
to change it's name. So if you save as foo.png, you change the name of the image
to foo.png. Perhaps the term Export is misleading here? The export step is
something the plug-in does to help you to save to the format you've choosen.
Comment 6 Sven Neumann 2004-10-28 23:22:51 UTC
Perhaps I haven't been clear here. Remember that you did not Export your image.
What you've choosen from the menu was "Save". The fact that the image needed to
be converted to fit the chosen file format does IMO not warrant to change the
semantics of Save. For exactly the use case you've outlined here, we've added
"Save a Copy".
Comment 7 karim nassar 2004-10-28 23:40:17 UTC
With all due respect, it seems that you are unconcerned that your (especially
the ignorant ones) Can lose data.

You say that I didn't export, but I did! The save dialog took me there changing
my intended task to export, because the software was smart enough to realize
that XCF and PNG are incompatible save targets. Perhaps this is an unexpected
path for a user to take, but  *it is possible to lose data*. The export dialog
told me "export conversion will not modify the original", very true. But it
certainly modified my working copy.

I don't expect to convince you that export and save as are the same thing, but I
would argue that novice users can't see the difference (e.g. ME :-)

May I kindly suggest that it work like this:

1: User opens XCF
2: Changes made
3: User clicks Save ("the wrong button")
4: Export says "I won't modify original, but I am gonna toss the changes you
made. Would you rather save as?"

If step two NOT taken, I wholeheartedly agree that the current functioning is
correct.

Comment 8 Sven Neumann 2004-10-29 12:36:01 UTC
Export doesn't modify the original nor does it toss away any changes. The only
modification to the copy that happened was that you've choosen to Save under a
certain name. Of course the image's name is changed then. This works this way in
every software I've ever seen. The only thing you could argue is wrong here is
that saving to PNG does unset the dirty flag even though the PNG format is not
necessarily capable of storing all image information. Changing that would be a
major inconvenience though.
Comment 9 Simon Budig 2004-10-29 12:48:52 UTC
Hmm. When thinking about it it seems like a good idea to keep the image dirty
when the export dialog was necessary. This would not cause the inconvenience for
images that *are* suitable for e.g. the PNG format and it would not cause the
data loss as described in the original bug report.
Comment 10 Sven Neumann 2004-10-29 13:24:52 UTC
We would have to keep the image dirty for all formats except XCF then since no
other image format is capable of handling all information in a GIMP image.
Comment 11 Simon Budig 2004-10-29 13:31:25 UTC
We right now have a solution that encourages data loss as described in the bug
report. My suggestion is a compromise between convenience and perfectionism. I
don't think that the loss of meta-data, paths etc. is as dramatic as the loss of
a complex layer structure, hence the export dialog is a good (and user visible)
place to draw the line.
Comment 12 Sven Neumann 2004-10-29 14:16:41 UTC
I don't think the current UI encourages data loss and I don't think the
suggested solution is reasonable. What I could imagine is to change Save to
always save to the XCF file format and add an Export menu item to export the
image to other file formats. The export filename would then have to be attached
to the image so that exporting again doesn't necessarily open the file chooser.
Comment 13 Joao S. O. Bueno 2004-10-29 15:30:48 UTC
Hmm...I think that what Sven proposes in #12 is too radical - it open space 
for people to criticize GIMP as not been able to save in different formats. 
(Belive me the world is full of such people when one tries to advocate Free 
Software). 
What Simon puts on #9, however seems reasonable. It is what OO.org already 
does, and works fine. Just keep the the image flag dirt, and find a way to 
show up a  different "unsaved warning", when closing/quiting than the one 
displayed for a non saved image at all.