After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 156718 - Polypaudio sink
Polypaudio sink
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins
git master
Other All
: Normal enhancement
: 0.8.6
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2004-10-28 14:48 UTC by mztabzrog
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description mztabzrog 2004-10-28 14:48:44 UTC 
This patch against current CVS HEAD adds support for a sink for output to a
polypaudio sound server.

http://0pointer.de/public/gst-plugins.patch
Comment 1 Ronald Bultje 2004-11-02 12:13:36 UTC 
* can you remove the g_print/g_message all around?
* what does the operation_unref() in the various state changes do?
Comment 2 Ronald Bultje 2004-11-02 12:31:53 UTC 
* your clocking code is fully commented *per line* (what a work!), can you
please change that to the ususal #if 0/#endif?
Comment 3 mztabzrog 2004-11-02 12:43:35 UTC 
i will remove the g_print() for you, i'll post the patch as soon as I am ready
with it.

pa_operation_unref() is used to decrement the reference count of the operation
object, effectively freeing it when it is no longer required.  In the polypaudio
API most operations are executed asynchronously. All those functions return an
operation object which may be used to cancel the operation or to explicitly wait
for it to be completed. In case I am not interested in canceling or waiting for
completion of such an asnychronous API call, I unref it immediately.

You're not an emacs user, are you? The "per line" commenting is the default
comment style on emacs when using the function "comment-region". And it makes sense.

Anyway, I'm going to change that to #if 0/#endif.

Lennart
Comment 4 mztabzrog 2004-11-04 18:52:03 UTC 
I've updated the patch now. It's now available on the same URL:

http://0pointer.de/public/gst-plugins.patch

Lennart
Comment 5 Ronald Bultje 2004-12-03 23:00:54 UTC 
This is in CVS now (and was included in 0.8.6).