After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 156676 - "Add Layer Mask" should auto-add image alpha channel if needed
"Add Layer Mask" should auto-add image alpha channel if needed
Status: RESOLVED FIXED
Product: GIMP
Classification: Other
Component: User Interface
unspecified
Other All
: Normal enhancement
: 2.2
Assigned To: GIMP Bugs
GIMP Bugs
Depends on:
Blocks:
 
 
Reported: 2004-10-28 09:45 UTC by Austin Donnelly
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Austin Donnelly 2004-10-28 09:45:03 UTC 
"Add Layer Mask" is currently greyed out if the image has no alpha channel.

Perhaps a better interface here would be to always have the "Add Layer
Mask" menu option available, but if there's no alpha channel then popup a
dialog saying something like "Adding a layer mask requires the image to have
an alpha channel.  Would you like me to add one? Yes: / No" (default yes,
tickbox (unchecked) for "don't ask me again").
Comment 1 Sven Neumann 2004-10-28 09:49:24 UTC 
Why do you special-case "Add Layer Mask"? This holds true for all menu items in
GIMP. Are we going to have a bug report for each of them?
Comment 2 Sven Neumann 2004-10-28 10:54:56 UTC 
I don't really see the point in popping up a dialog. If a layer mask requires an
alpha channel (it is unfortunate that it does but I guess we can't change that)
then the code should just add one.

2004-10-28  Sven Neumann  <sven@gimp.org>

	* app/actions/layers-actions.c (layers_actions_update): do not set
	the "layers-mask-add" action insensitive if there's no alpha channel.

	* app/actions/layers-commands.c (layers_add_mask_response): add an
	alpha channel if there isn't one already. Fixes bug #156676.