After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 156399 - Changes to try and allow building without gtk-doc break the build.
Changes to try and allow building without gtk-doc break the build.
Status: VERIFIED INCOMPLETE
Product: libgsf
Classification: Core
Component: General
unspecified
Other All
: Normal normal
: ---
Assigned To: Jody Goldberg
Jody Goldberg
Depends on:
Blocks:
 
 
Reported: 2004-10-25 15:07 UTC by James Henstridge
Modified: 2009-08-15 18:40 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description James Henstridge 2004-10-25 15:07:09 UTC
Jody recently made a change to configure.in with the following comment:
  revision 1.76
  date: 2004/10/24 16:26:14;  author: jody;  state: Exp;  lines: +3 -3
  Make the gtk-doc depend optional

This changed the simple GTK_DOC_CHECK macro call to the following:
  ifdef([GTK_DOC_CHECK],[GTK_DOC_CHECK([1.0])],[gtk_doc_installed=false])

This breaks libgsf builds on a fresh checkout.  The common gnome-autogen.sh
script will only run gtkdocize if the configure.in script matches the pattern
"^GTK_DOC_CHECK", which the above line doesn't.

If gtkdocize isn't run, then the gtk-doc.make file won't be installed into the
build tree, which causes automake to barf when trying to process
doc/Makefile.am, which tries to include it.

Given that this change breaks the build, and doesn't actually make it build
without gtk-doc installed, it should probably be reverted.
Comment 1 Jody Goldberg 2004-10-25 15:23:38 UTC
I'd prefer to fix it.  The win32 builders are not thrilled with installing gtk-doc

We can kludge the test to read
    ifdef([GTK_DOC_CHECK],[
    GTK_DOC_CHECK([1.0])
    ],[gtk_doc_installed=false])
To fake out the test and get it working for autogen

I'd hoped the AM_CONDITIONAL wrapper for the include would be sufficient
we could kludge that too and touch an empty file if need be, but that seems
really ugly.  Any other thoughts ?
Comment 2 James Henstridge 2004-10-25 15:30:26 UTC
Anything run from within configure will be too late.  Automake processes include
statements internally, so autogen.sh will have failed long before it attempts to
run configure.

The above also looks like it may cause newer automake versions to not pull in
gtk-doc.m4, since they might notice that the macro isn't actually called (I
haven't checked this yet).

Making gtk-doc less of a chore to install is probably a better course of action.
Comment 3 Jody Goldberg 2004-10-25 15:38:29 UTC
damn
reverted.