After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 156162 - startup notification zoom animation leaves artifacts behind
startup notification zoom animation leaves artifacts behind
Status: RESOLVED FIXED
Product: gnome-panel
Classification: Other
Component: panel
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Panel Maintainers
Panel Maintainers
: 153996 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2004-10-22 15:50 UTC by Matthias Clasen
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
fix the issue by storing the integer coords (2.28 KB, patch)
2004-10-22 15:51 UTC, Matthias Clasen
accepted-commit_now Details | Review

Description Matthias Clasen 2004-10-22 15:50:16 UTC
I see a yellow line at the right edge of the monitor left behind. The code in
xstuff.c:draw_zoom_animation() looks obfuscated, but technically correct. The
bug seems to be that rounding the same float values to integer coords gives
different results...
Comment 1 Matthias Clasen 2004-10-22 15:51:39 UTC
Created attachment 32929 [details] [review]
fix the issue by storing the integer coords

Maybe the code should be cleaned up to avoid all the unnecessary length one
loops...
Comment 2 Vincent Untz 2004-10-29 14:47:42 UTC
Comment on attachment 32929 [details] [review]
fix the issue by storing the integer coords

Weird. But I believe you :-)
Ok for HEAD and gnome-2-8
Comment 3 Mark McLoughlin 2004-11-26 16:55:27 UTC
*** Bug 153996 has been marked as a duplicate of this bug. ***
Comment 4 Mark McLoughlin 2004-11-26 17:01:11 UTC
Nice one Matthias :-)

2004-11-26  Mark McLoughlin  <mark@skynet.ie>

        Patch from Matthias Clasen <mclasen@redhat.com> in
        bug #156162

        * xstuff.c: (draw_zoom_animation): round the integer
        co-ords only once since we seem to sometimes get
        different results.