After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 155913 - 'Add to panel->launcher' failed when logged in as root in solaris.
'Add to panel->launcher' failed when logged in as root in solaris.
Status: RESOLVED FIXED
Product: libgnome
Classification: Deprecated
Component: general
unspecified
Other Solaris
: Normal normal
: ---
Assigned To: libgnome maintainer
libgnome maintainer
Depends on:
Blocks:
 
 
Reported: 2004-10-20 06:24 UTC by Vinay M R
Modified: 2005-05-12 09:06 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch fixes the bug. (1.54 KB, patch)
2004-10-20 06:32 UTC, Vinay M R 		none Details | Review

Description Vinay M R 2004-10-20 06:24:07 UTC 
Steps to reproduce:
1. Right click panel, and choose 'add to panel->launcher' in the popup menu
2. 'create launcher' dialog will popup. enter some text in name field and enter
'gedit' in command field, then click ok.

Bug:Error dialog popup and show:can't save launcher to disk.
Comment 1 Vinay M R 2004-10-20 06:32:31 UTC 
Created attachment 32815 [details] [review]
Patch fixes the bug.

This happens only on solaris machines, here `g_get_home_dir ()` returns "/" for
the `root`, and not as "/root" as in case of linux. Here we use
`gnome_util_home_file` macro to get the path, which internally concatenates "/"
with home_dir. Hence the Path will be set to "//.gnome2/...." instead of
"/.gnome2/....". Then later on gnome-vfs calls (gnome_vfs_create_uri()) are
made, where it is not able to create a uri for this. Hence the bug.

This bug can be fixed by using `g_build_filename` instead of `g_strconcat` in
`gnome_util_home_file` macro  (which is a part of libgnome), which returns
proper path.
Comment 2 Kjartan Maraas 2005-05-11 09:10:06 UTC 
Has this been tested on other platforms than Solaris so we don't fix it on one
and break it on others?
Comment 3 Vinay M R 2005-05-11 09:38:20 UTC 
Yes, It works fine on both Solaris and linux.
Comment 4 Kjartan Maraas 2005-05-12 09:06:59 UTC 
Ok. Commited on both branches.