GNOME Bugzilla – Bug 155603
Unsaved Form Changes dialog triggers false positives
Last modified: 2011-05-19 13:18:03 UTC
The unsaved form changes dialog appears in gmail even after you've sent/cancelled sending a message and returned to the inbox (or whatever) because the form is hidden in the background.
confirmed.
It happens in some other websites too, without apparent reason. For example, see http://ploum.fritalk.com/showthread.html in a ew tab and try to close the tab. It's particulary annoying when browsing such a website and you have to confirm every tab you read. It doesn't happen in firefox.
Created attachment 52745 [details] [review] possible fix Can everyone who's seeing this problem please try the patch and report its output on sites where it still erroneously claims it has modified fields? It fixes the site from comment 2 for me, at least.
I don't see this issue anymore with 1.9.3.1 on Dapper. Can this be closed?
*** Bug 325109 has been marked as a duplicate of this bug. ***
Patch confirmed on 1.8.x
So let's get this patch in at least (it doesn't fix all sites though; I still see the warning on google maps for example). The patch needs some cleanup (move includes to top, remove g_prints()s).
The first patch is committed: http://mail.gnome.org/archives/cvs-commits-list/2006-January/msg04425.html We still have problems with gmail and google maps, so leaving open
I think we need to completely change the way we detect whether the form was modified. I think the following way should work: Add a nsIDOMFormListener to our event listeners, and listen for onreset, onsubmit, onchange and oninput. In ::Input (and maybe in ::Changed [not sure, since this might be used by script too?]) we mark the form as 'changed', and in ::Submit and ::Reset, we remove the mark. The problem is how to store the 'changed' bit... perhaps nsIDOM3Node::SetUserData , but not if that's accessible from content (don't know if it is)...
Oh and we also need to handle documents with designmode=on; no idea how to do that, yet.
*** Bug 345786 has been marked as a duplicate of this bug. ***
This problem also occurs with any article in The Onion, such as <http://www.theonion.com/content/node/40091>.
still valid.
Until this feature is fixed, would it be possible to allow this feature to be disabled (by the user, perhaps through about:config)? In fact, it would be nice to be able to disable it anyway. I find it really anoying to have to click "Close Document" all the time.
*** Bug 459365 has been marked as a duplicate of this bug. ***
*** Bug 574538 has been marked as a duplicate of this bug. ***
No longer valid for current webkit-based Epiphany versions.