After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 155382 - address expansion from addressbook fails
address expansion from addressbook fails
Status: RESOLVED FIXED
Product: balsa
Classification: Other
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Balsa Maintainers
Balsa Maintainers
: 166030 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2004-10-14 12:51 UTC by Georg Steffers
Modified: 2005-05-16 02:59 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Little Brother output for multiple addresses to a contact (147 bytes, application/octet-stream)
2005-05-12 15:49 UTC, Andrew Lau
Details

Description Georg Steffers 2004-10-14 12:51:39 UTC
- create a vcard file which embeds multiple email adresses to one name. I used
this one:

BEGIN:VCARD
FN:Georg Steffers
N:Steffers;Georg
EMAIL;INTERNET:georg@steffers.org
EMAIL;INTERNET:georg@steffers.net
END:VCARD

- Use this file as addressbook in balsa-2.2.5. 
- Compose an email using the FN, or one of the email adresses from the file.
- first thing you should notice is: not all email addresses are shown in the to line
- when sending the mail my postfix sais something like this to me:

Oct 14 14:37:46 onkels postfix/smtpd[16942]: E52494131F0: reject: RCPT from
localhost[127.0.0.1]: 450 <  B   B >: User unknown in local recipient table;
from=<georg@steffers.org> to=<??B???B?> proto=ESMTP helo=<onkels>

- Balsa seems to have messed up the complere to address.
- Using addressbooks with only one email-address per name seems to work correct.
Comment 1 Peter Bloomfield 2004-11-11 00:58:06 UTC
Thanks for the report!  The address completion code has been updated in
cvs--could you try it?
Comment 2 Andrew Lau 2005-02-02 12:45:59 UTC
*** Bug 166030 has been marked as a duplicate of this bug. ***
Comment 3 Andrew Lau 2005-02-02 15:36:03 UTC
Here's core dump of this bug:
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=293305
Comment 4 Andrew Lau 2005-05-12 14:38:12 UTC
Hi guys. I've just done some testing with 2.3.2 and address expansion only works
for contacts with one email address to their names.

Please mark this as confirmed.

Cheers,
Andrew "Netsnipe" Lau
Comment 5 Pawel Salek 2005-05-12 14:40:35 UTC
You could reproduce it with VCARD address book, I presume?
Comment 6 Andrew Lau 2005-05-12 14:51:36 UTC
Yep.

% cat foo.vcard
BEGIN:VCARD
FN:Andrew Lau
N:Lau;Andrew
REV:2005-02-02T12:17:31
EMAIL;INTERNET:netsnipe@localhost
EMAIL;INTERNET:netsnipe@espresso.caffeine
END:VCARD

BEGIN:VCARD
FN:Some One Else
N:Else;Some;One
REV:2005-05-12T14:35:28
EMAIL;INTERNET:foo@bar.com
END:VCARD
Comment 7 Andrew Lau 2005-05-12 15:26:13 UTC
I've confirmed it via an external program (Little Brother DB) as well.

Any chance there could be a backported fix for 2.3.0 within the next 24-48
hours? Or would it be too messy?
Comment 8 Peter Bloomfield 2005-05-12 15:43:27 UTC
The externq code may need this patch:

diff -u -r1.16 address-book-extern.c
--- libbalsa/address-book-extern.c      8 May 2005 16:14:30 -0000       1.16
+++ libbalsa/address-book-extern.c      12 May 2005 15:42:44 -0000
@@ -391,7 +391,7 @@
     if(!parse_externq_file(ex, (gchar *)prefix, lbe_expand_cb, &res))
         return NULL;

-    g_list_reverse(res);
+    res = g_list_reverse(res);

     if(res != NULL && new_prefix)
         *new_prefix = internet_address_to_string(res->data, FALSE);
Comment 9 Peter Bloomfield 2005-05-12 15:45:25 UTC
BTW: I coundn't reproduce any problem with vcards.  I installed foo.vcard, and
both of Andrew's addresses were offered as completions: as two addresses or as
one address list, depending on the treatment of multiple addresses.  I added
Georg's card, and that also offered correct completions.
Comment 10 Andrew Lau 2005-05-12 15:48:20 UTC
OK. My bad. I've had a long time backporting and debugging patches.

Autocomplete does indeed work in 2.3.0 with the backported patch from #303421.
But however, it's a bit slow (hence why I thought it didn't work at first), and
it only returns the first match.

Attached is output from lbdbq for a contact that has multiple contacts.
Comment 11 Andrew Lau 2005-05-12 15:49:09 UTC
Created attachment 46372 [details]
Little Brother output for multiple addresses to a contact
Comment 12 Andrew Lau 2005-05-12 16:00:56 UTC
> The externq code may need this patch:

Yep. That fixed it!
Comment 13 Peter Bloomfield 2005-05-12 16:10:13 UTC
OK--committing to cvs.

Peter
Comment 14 Georg Steffers 2005-05-14 13:33:48 UTC
I tried 2.3.2 and it works for me. Thanks to the developers!
Comment 15 Peter Bloomfield 2005-05-16 02:59:32 UTC
Thanks for checking!  Resolving as FIXED...