After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 155283 - Rhythmbox doesn't encode URL properly making firefox misbehave
Rhythmbox doesn't encode URL properly making firefox misbehave
Status: RESOLVED OBSOLETE
Product: rhythmbox
Classification: Other
Component: general
0.8.6
Other Linux
: Normal normal
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
: 160025 170929 300976 304762 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2004-10-13 10:49 UTC by Loïc Minier
Modified: 2005-09-04 03:38 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Loïc Minier 2004-10-13 10:49:15 UTC
(this is Debian http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=225088 )

- Configure firefox as your GNOME browser
- Play a song in an Album or from an Artist with a space in its name
- click on the allmusic link in the top of rhythmbox

The problem is that firefox interprets "|" as a "Create new tab" separator, and
allmusic.com only accepts "|" as a space between words.  I tried to url_encode()
the "|", but allmusic.com does not accept hex encoded chars in the URL (this is
a real problem here, they're running Microsoft-IIS/5.0).

I tried sending a %20, a %7C ("|"), and a + instead of the |, and the search
worked in all cases, but the search title in the page contained the litteral
characters I typed in the URL and this is UGLY!

Now firefox is right in using | as an extension mechanism, and allmusic is wrong
in not conforming to HTTP specs, what we can fix is rhythmbox, to send "+"
instead of "|".  It's ugly because "MOON+SAFARI" is displayed instead of "MOON
SAFARI" in the search results, but it works.

To do this, remove the two while loops with a '|' in widgets/rb-header.c,
*_info_url will get the quoting right.


Side note, it would be best to use a real URL encoding function.
Comment 1 Christophe Fergeau 2005-01-08 23:30:48 UTC
*** Bug 160025 has been marked as a duplicate of this bug. ***
Comment 2 Sebastien Bacher 2005-06-04 12:35:20 UTC
*** Bug 170929 has been marked as a duplicate of this bug. ***
Comment 3 Sebastien Bacher 2005-06-04 12:35:40 UTC
*** Bug 304762 has been marked as a duplicate of this bug. ***
Comment 4 Sebastien Bacher 2005-06-04 12:36:32 UTC
*** Bug 300976 has been marked as a duplicate of this bug. ***
Comment 5 Sven Arvidsson 2005-07-29 13:05:51 UTC
I can't reproduce this with Rb 0.8.8 and Firefox 1.06 (even tried with Epiphany
1.6.4). Seems like Rb still uses | as a space, so maybe something in the way
Firefox starts new tabs has changed?
Comment 6 James "Doc" Livingston 2005-09-04 03:38:43 UTC
We've switched to using last.fm, rather than allmusic.com, so this shouldn't
happend any more.