After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 154815 - [PATCH] ffmpegcolorspace leaks caps
[PATCH] ffmpegcolorspace leaks caps
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins
0.8.5
Other Linux
: Normal minor
: 0.8.7
Assigned To: GStreamer Maintainers
GStreamer Maintainers
: 157246 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2004-10-07 18:41 UTC by Sebastien Cote
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
fix for gst-plugins (450 bytes, patch)
2004-10-07 18:42 UTC, Sebastien Cote 		none Details | Review
fix for gst-ffmpeg (410 bytes, patch)
2004-10-07 18:43 UTC, Sebastien Cote 		none Details | Review

Description Sebastien Cote 2004-10-07 18:41:47 UTC 
Caps are not freed after a call to gst_pad_try_set_caps(). This applies to the
filter in gst-plugins as well as the one in gst-ffmpeg.
Comment 1 Sebastien Cote 2004-10-07 18:42:37 UTC 
Created attachment 32360 [details] [review]
fix for gst-plugins
Comment 2 Sebastien Cote 2004-10-07 18:43:44 UTC 
Created attachment 32362 [details] [review]
fix for gst-ffmpeg
Comment 3 Ronald Bultje 2004-10-09 20:50:11 UTC 
Doesn't gst_pad_try_set_caps() take ownership over caps?...
Comment 4 Sebastien Cote 2004-10-09 21:07:07 UTC 
If there's a problem, it just returns. If everything seems ok, it makes a copy
before calling gst_pad_link_try().
Comment 5 Ronald Bultje 2004-11-07 12:18:43 UTC 
*** Bug 157246 has been marked as a duplicate of this bug. ***
Comment 6 Sebastien Cote 2004-11-08 17:02:31 UTC 
Silly me... The first patch calls 
  gst_pad_free (newothercaps)
instead of 
  gst_caps_free (newothercaps)
Comment 7 Christian Fredrik Kalager Schaller 2004-12-04 21:01:22 UTC 
This should be merged for next release.
Comment 8 Stephane Loeuillet 2004-12-12 14:05:39 UTC 
status update please

was it applied ? when ? in which release ?

if not yet applied, is it still needed ?

confirming bug, adding PATCH keyword
Comment 9 Ronald Bultje 2004-12-16 12:29:11 UTC 
Both applied, thanks.