After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 154692 - [PATCH] make unlink_many element_unlink_many
[PATCH] make unlink_many element_unlink_many
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-python
git master
Other Linux
: Normal normal
: 0.8.0
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2004-10-06 15:01 UTC by Zaheer Abbas Merali
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch to gst.defs (486 bytes, patch)
2004-10-06 15:01 UTC, Zaheer Abbas Merali
none Details | Review
patch to gst.defs and gst.override (1.36 KB, patch)
2004-10-06 15:27 UTC, Zaheer Abbas Merali
none Details | Review

Description Zaheer Abbas Merali 2004-10-06 15:01:11 UTC
makes it more consistent
Comment 1 Zaheer Abbas Merali 2004-10-06 15:01:37 UTC
Created attachment 32292 [details] [review]
patch to gst.defs
Comment 2 Zaheer Abbas Merali 2004-10-06 15:27:28 UTC
Created attachment 32294 [details] [review]
patch to gst.defs and gst.override

whoops forgot a cpl of things
Comment 3 Johan (not receiving bugmail) Dahlin 2004-10-10 20:47:46 UTC
You need to increase the ref count for Py_None before returning this:

  Py_INCREF(Py_None);
  return Py_None;

Appart from that it's fine, please commit.

FYI: We should probably allow multiple arguments to link instead of having a
separate link and link_many.
Comment 4 Zaheer Abbas Merali 2004-10-11 09:48:07 UTC
Ok thx, committed now.

link and unlink are methods of the Element object.  I dont think its logical to
make link and unlink take multiple arguments because semanically it is
wrong...due to the element arguments after the first argument are not connected
to that Element object.

Persoanlly, I think its better the current way.