GNOME Bugzilla – Bug 154248
Tabbed Browsing
Last modified: 2005-10-01 22:09:06 UTC
It would be really handy to have tabbed browsing, so that when looking a reference links in a document you can flip between them. Middle click to open in a new tab, just like in epiphany.
*** Bug 164052 has been marked as a duplicate of this bug. ***
I really would like to see this as well.
Created attachment 52301 [details] [review] rough first implementation of tabs I'm new to gobject, but I've come up with a rough implementation for tabs in devhelp. Not very accessible with this patch, but basically a middle click on a link will open a new tab. It's been pretty solid stability wise here. It would be nice to get some feedback and testing.
I use Debian unstable. I tried to compile the patched devhelp-0.10 using mozilla-dev package (Version: 2:1.7.11-1) and got following message: make[3]: Entering directory `/home/karma/temp/devhelp/devhelp-0.10/src' /bin/sh ../libtool --tag=CC --mode=link gcc -g -O2 -Wall -Wno-uninitialized -Wchar-subscripts -Wmissing-declarations -Wmissing-prototypes -Wnested-externs -Wpointer-arith -Wno-sign-compare -o devhelp -R/usr/lib/mozilla dh-main.o -lgtk-x11-2.0 -lgdk-x11-2.0 -latk-1.0 -lgdk_pixbuf-2.0 -lm -lpangoxft-1.0 -lpangox-1.0 -lpangoft2-1.0 -lpango-1.0 -lgobject-2.0 -lgmodule-2.0 -ldl -lglib-2.0 libdevhelp-1.la gcc -g -O2 -Wall -Wno-uninitialized -Wchar-subscripts -Wmissing-declarations -Wmissing-prototypes -Wnested-externs -Wpointer-arith -Wno-sign-compare -o .libs/devhelp dh-main.o /usr/lib/libgtk-x11-2.0.so /usr/lib/libgdk-x11-2.0.so /usr/lib/libatk-1.0.so /usr/lib/libgdk_pixbuf-2.0.so -lm /usr/lib/libpangoxft-1.0.so /usr/lib/libpangox-1.0.so /usr/lib/libpangoft2-1.0.so /usr/lib/libpango-1.0.so /usr/lib/libgobject-2.0.so /usr/lib/libgmodule-2.0.so -ldl /usr/lib/libglib-2.0.so ./.libs/libdevhelp-1.so -Wl,--rpath -Wl,/opt/lib -Wl,--rpath -Wl,/usr/lib/mozilla ./.libs/libdevhelp-1.so: undefined reference to `mozilla_get_mouse_event_button' collect2: ld returned 1 exit status
looks like it might be libtool related.. Can delete the current source directory, pull it from cvs, apply the patch and _then_ run "./autogen.sh" and "make && make install"?
I just tried the patch, it seems to work pretty nicely. The close button seems to be a bit too big though, making the tab labels too heigh.
The patch worked on CVS version (from 2005-09-25). Tabs make the work with devhelp much, much easier. It would be nice to have a posibility to close tabs from the keyboard (CTRL+W), it doesn't work now.
The patch doesn't apply anymore, I've changed dh-window.c pretty much to add support for multiple windows.
Richard: So are you saying that you prefer multiple windows over tab support? Or are you just letting me know that the patch no longer works with the added feature of multiple windows?
Sorry, I would very much like to have tab support :) If you don't have time to update the patch, I might do it.
A few comments on the patch: The code in mozilla.cpp could be put in the existing cpp file we already have for gecko glue. There are a few style inconsistencies, like no space before "(" sometimes, and the variables and function arguments are not lined up like the rest of the code. I'm not so sure about the close buttons actually, they are kind of easy to hit by accident, and they mess up the height of the tabs so they don't align with the tabs at the left.
Created attachment 52918 [details] [review] new patch to implement tabs in devhelp This patch should apply over current CVS. It's basically the same as the last patch except when you switch tabs, it also switches the title of the window. I'm going to look into how to make the close button smaller so that it lines up with the other notebook tabs.
Oh, also the gecko stuff was put in the dh-gecko-utils.[ch] files as suggested so no Makefile.am changes were necessary, and all the style inconsistencies should be fixed.
Thanks! I've committed tab support now based on your patch. I removed the close buttons and added shortcuts for opening and closing tabs.