GNOME Bugzilla – Bug 153855
gnopernicus has narrow cells against two column chars.
Last modified: 2004-12-22 21:47:04 UTC
1. Login into GNOME on ja_JP.UTF-8. 2. Invoke gnopernicus and enable brlmonitor. 3. Activate any Japanese multibyte chars. Then the cells are too narrow. Suggested fix: --- gnopernicus-0.9.10/brlmon/brlmonui.c.orig 2004-09-27 11:39:17.962589000 +0900 +++ gnopernicus-0.9.10/brlmon/brlmonui.c 2004-09-27 13:25:13.186362000 +0900 @@ -1327,6 +1327,12 @@ brlmon_get_screen_size (&x_screen, &y_screen); brlmon_cell_frame_x_size = (gint)(x_screen / (column + STATUS_CELL_COUNT)); + if ( brlmon_cell_frame_x_size <= brlmon_font_size * 2 + 7) { + brlmon_cell_frame_x_size = brlmon_font_size * 2 + 7; + column = (gint)(x_screen / brlmon_cell_frame_x_size) - STATUS_CELL_COUNT; + our_resize_width = width; + brlmon_set_int (column, BRAILLE_MONITOR_COLUMN_GCONF_KEY); + } brlmon_cell_frame_y_size = brlmon_font_size + 2 * CELL_MARGINE; width = x_screen; (courtesy of takao.fujiwara@sun.com 2004-09-28)
User has the possibility to increase brlmon's cells width by decreasing the number of columns (go to Gnopernicus->Preferences->Braille Monitor, and decrease Column value). I apply this patch and the Japanese chars looks right after the cell's width was increased. But after login into GNOME on en_US the dimension was the same, to big in my opinion for our chars.
Until we can generate Japanese Braille, I think this is not a P2/AP1 bug, but rather of lower priority.
I do not understand why is this a bug. User has also the posibility to change font size from Gnopernicus->Preferences->Braille Monitor.
yes, and in any case the patch isn't quite correct (it always reserves space for "double width" characters).
Why is it not a bug? The cells are always narrow in multibyte environemnt by default. OK, I'll provide the second patch. Please wait for it.
Created attachment 32100 [details] [review] patch for brlmonitor.schemas.in Added the new patch to localize the cell size.
Created attachment 32101 [details] [review] patch for POTFILES.in Added the patch for potfile.
The second patch is to localize the defualt cell size. Then we can configure the cell size by locale.
BTW, the latest tarball misses the following files: gnopi/gnopernicus.desktop.in srcore/verbose.xml.in Please add those files into the tarball. They are needed for the translation.
Bug #154153 is filled for comment #9.
Bug #154153 is filled for comment #6.
Takao: note also that verbose.xml.in is missing from POTFILES.in. We can't change this in the gnome-2.8 branch but you will need to be aware of this when preparing new translations.
Comment on attachment 32101 [details] [review] patch for POTFILES.in All files added here are disabled for moment (except brlmon.schemas.in, which is subject of another bug).
Update for comment #11 "Bug #154153 is filled for comment #7". Bug #154161 is filled for comment #6. Since the original problem is subject of bug #154161, I'm closing this bug as duplicate of #154161. *** This bug has been marked as a duplicate of 154161 ***