After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 153621 - Problems with icon loading code
Problems with icon loading code
Status: RESOLVED FIXED
Product: libegg
Classification: Other
Component: recent-files
unspecified
Other All
: Normal normal
: ---
Assigned To: James Willcox
James Willcox
Depends on:
Blocks:
 
 
Reported: 2004-09-24 08:47 UTC by James Henstridge
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
recent-files-pixbuf-loading.patch (2.92 KB, patch)
2004-09-24 08:48 UTC, James Henstridge
none Details | Review

Description James Henstridge 2004-09-24 08:47:39 UTC
While working on a bug in the Panel for Ubuntu
(https://bugzilla.ubuntu.com/show_bug.cgi?id=1587), I ran into a problem with
the recent-files code.

When loading icons for the recently used files, gdk_pixbuf_new_from_file() is
being used, which doesn't pass a desired size to the loader backend.

For the SVG backend, this will cause it to load at the file's default size which
might be a lot larger (or smaller) and require scaling.  By using
gdk_pixbuf_new_from_file_at_size() the backend can render the SVG at the correct
size, which saves time and memory since the image doesn't need to be scaled.

Attached is a patch that fixes this.
Comment 1 James Henstridge 2004-09-24 08:48:22 UTC
Created attachment 31895 [details] [review]
recent-files-pixbuf-loading.patch
Comment 2 James Willcox 2004-09-24 22:42:49 UTC
Patch looks good.  Thanks James.
Comment 3 James Henstridge 2004-09-27 09:31:55 UTC
Okay, I've checked this into the libegg module now, and emailed d-d-l about the
change so that users of the code know to update if appropriate.