GNOME Bugzilla – Bug 153621
Problems with icon loading code
Last modified: 2004-12-22 21:47:04 UTC
While working on a bug in the Panel for Ubuntu (https://bugzilla.ubuntu.com/show_bug.cgi?id=1587), I ran into a problem with the recent-files code. When loading icons for the recently used files, gdk_pixbuf_new_from_file() is being used, which doesn't pass a desired size to the loader backend. For the SVG backend, this will cause it to load at the file's default size which might be a lot larger (or smaller) and require scaling. By using gdk_pixbuf_new_from_file_at_size() the backend can render the SVG at the correct size, which saves time and memory since the image doesn't need to be scaled. Attached is a patch that fixes this.
Created attachment 31895 [details] [review] recent-files-pixbuf-loading.patch
Patch looks good. Thanks James.
Okay, I've checked this into the libegg module now, and emailed d-d-l about the change so that users of the code know to update if appropriate.