After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 153585 - g_object_get does not work for "dash"
g_object_get does not work for "dash"
Status: RESOLVED FIXED
Product: libgnomecanvas
Classification: Deprecated
Component: core
CVS HEAD
Other Linux
: Normal normal
: ---
Assigned To: Sven Herzberg
Federico Mena Quintero
Depends on:
Blocks:
 
 
Reported: 2004-09-23 19:17 UTC by Peter G. Baum
Modified: 2006-11-17 13:15 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Peter G. Baum 2004-09-23 19:17:38 UTC
g_object_set expects a pointer to ArtVpathDash. 
But g_object_get returns a pointer to double values.
Here is the patch to fix it:

*** gnome-canvas-shape.c        2004-09-23 21:13:34.879523048 +0200
--- gnome-canvas-shape-orig.c   2004-09-23 21:00:37.291734360 +0200
***************
*** 625,631 ****
                break;
   
        case PROP_DASH:
!               g_value_set_pointer (value, &priv->dash);
                break;
   
        default:
--- 625,631 ----
                break;
   
        case PROP_DASH:
!               g_value_set_pointer (value, priv->dash.dash);
                break;
   
        default:
Comment 1 Kjartan Maraas 2006-10-25 19:10:23 UTC
Is this patch reversed? I guess you should use diff -up original-file.c patched-file.c
Comment 2 Sven Herzberg 2006-11-11 10:43:42 UTC
I basically agree here. But doesn't this break ABI with existing applications?
Comment 3 Sven Herzberg 2006-11-17 13:15:17 UTC
2006-11-17  Sven Herzberg  <herzi@gnome-de.org>

        * src/gnome-canvas-shape.c: changed the get_property() implementation
        for "dash" to return something useful (ArtVpathDash*) and also to be
        consistent with set_property() ('though tis code really sucks as we
        should really use GParamSpecBoxed instead). Closes bug #153585
        (Patch by Peter G. Baum)