After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 153521 - right click for setting tab title
right click for setting tab title
Status: RESOLVED FIXED
Product: gnome-terminal
Classification: Core
Component: general
unspecified
Other All
: Normal enhancement
: gnome-2-24
Assigned To: GNOME Terminal Maintainers
GNOME Terminal Maintainers
: 312811 539473 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2004-09-23 09:24 UTC by Karl Eichwalder
Modified: 2008-07-11 21:30 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Add notebook popup menu (4.09 KB, patch)
2008-07-05 12:09 UTC, Maxim Ermilov
needs-work Details | Review
Add notebook popup menu(Corrected patch) (5.22 KB, patch)
2008-07-06 16:32 UTC, Maxim Ermilov
none Details | Review

Description Karl Eichwalder 2004-09-23 09:24:23 UTC
My proposal is to make the tab right click aware.  Right clikcing on a tab it
should be possible to set the tab title.
Comment 1 Olav Vitters 2005-01-03 22:51:28 UTC
See also bug 109778, asks for the same but wants middle mouse button.
Comment 2 Karl Eichwalder 2005-01-04 07:25:27 UTC
Right click should display a context menu and one item of this context menu
ought to set the title.  Middle mouse button is reserved for pasting (even Emacs
developers recently agreed to "adjust" Emacs).

For reference see firefox' tab browsing.

I hope this helps to take a good decision :)
Comment 3 Kjartan Maraas 2005-09-20 11:13:44 UTC
*** Bug 312811 has been marked as a duplicate of this bug. ***
Comment 4 Piotr Smyrak 2006-08-08 12:20:32 UTC
I strongly second this proposition. Currently when one uses g-t with no menu, to set custom title on tab, one has to right click, make the menu visible, browse to "Set title", assign new title, hide the menu. It sucks.

Of course there are other hacker's way to change the title, but such an action - right click on tab, display a menu and set title - would be much more user friendly and evident.
Comment 5 Luis Menina 2007-03-28 12:38:27 UTC
Please close as duplicate of bug 170096, which wants the feature with left double click.
Comment 6 Christian Persch 2008-05-29 19:54:21 UTC
Easy to fix; look at epiphany's notebook code for how it's done.
Comment 7 Christian Persch 2008-06-22 12:11:15 UTC
*** Bug 539473 has been marked as a duplicate of this bug. ***
Comment 8 Maxim Ermilov 2008-07-05 12:09:32 UTC
Created attachment 114018 [details] [review]
Add notebook popup menu
Comment 9 Christian Persch 2008-07-05 20:41:08 UTC
Thanks for the patch!

A few comments:
- some code style issue: { } is indented too in g-t, e.g.
 if (x)
   {
     do it
   }
- add all the code to terminal-window.c, not part to terminal-tabs-menu
- I think you need to check which tab was clicked on in order not to popup the menu when not clicked on a tab label (like ephy code does in ephy-notebook.c)
- when popping up the menu with the keyboard, a menu positioning function needs to be used like ephy does
Comment 10 Maxim Ermilov 2008-07-05 22:49:05 UTC
Thanks for your reply!

I have some question:
- add all the code to terminal-window.c, not part to terminal-tabs-menu
How can I accesses for private member of structure TerminalWindowPrivate from other file?
(window->priv->ui_manager;window->priv->action_group)
- when popping up the menu with the keyboard, a menu positioning function needs
to be used like ephy does
Why need to check this? (Sorry for maybe stupid question but I realy don't know How can I select tab from keyboard in g.-t.?)
Comment 11 Christian Persch 2008-07-06 09:30:18 UTC
(In reply to comment #10)
> Thanks for your reply!
> 
> I have some question:
> - add all the code to terminal-window.c, not part to terminal-tabs-menu
> How can I accesses for private member of structure TerminalWindowPrivate from
> other file?
You can't, that's why the code should be in terminal-window.c.

> - when popping up the menu with the keyboard, a menu positioning function needs
> to be used like ephy does
> Why need to check this? (Sorry for maybe stupid question but I realy don't know
> How can I select tab from keyboard in g.-t.?)

Click with the mouse on the tab label so that it gets the focus, then press Shift-F10.
Comment 12 Maxim Ermilov 2008-07-06 16:32:54 UTC
Created attachment 114068 [details] [review]
Add notebook popup menu(Corrected patch)

Corrected all as described with one exception(pop up the menu with the keyboard is not enabled)
Comment 13 Christian Persch 2008-07-07 20:54:39 UTC
Thanks! I fixed some more issues and committed to svn trunk.
Comment 14 Christian Persch 2008-07-11 21:30:07 UTC
*** Bug 542588 has been marked as a duplicate of this bug. ***