GNOME Bugzilla – Bug 153521
right click for setting tab title
Last modified: 2008-07-11 21:30:07 UTC
My proposal is to make the tab right click aware. Right clikcing on a tab it should be possible to set the tab title.
See also bug 109778, asks for the same but wants middle mouse button.
Right click should display a context menu and one item of this context menu ought to set the title. Middle mouse button is reserved for pasting (even Emacs developers recently agreed to "adjust" Emacs). For reference see firefox' tab browsing. I hope this helps to take a good decision :)
*** Bug 312811 has been marked as a duplicate of this bug. ***
I strongly second this proposition. Currently when one uses g-t with no menu, to set custom title on tab, one has to right click, make the menu visible, browse to "Set title", assign new title, hide the menu. It sucks. Of course there are other hacker's way to change the title, but such an action - right click on tab, display a menu and set title - would be much more user friendly and evident.
Please close as duplicate of bug 170096, which wants the feature with left double click.
Easy to fix; look at epiphany's notebook code for how it's done.
*** Bug 539473 has been marked as a duplicate of this bug. ***
Created attachment 114018 [details] [review] Add notebook popup menu
Thanks for the patch! A few comments: - some code style issue: { } is indented too in g-t, e.g. if (x) { do it } - add all the code to terminal-window.c, not part to terminal-tabs-menu - I think you need to check which tab was clicked on in order not to popup the menu when not clicked on a tab label (like ephy code does in ephy-notebook.c) - when popping up the menu with the keyboard, a menu positioning function needs to be used like ephy does
Thanks for your reply! I have some question: - add all the code to terminal-window.c, not part to terminal-tabs-menu How can I accesses for private member of structure TerminalWindowPrivate from other file? (window->priv->ui_manager;window->priv->action_group) - when popping up the menu with the keyboard, a menu positioning function needs to be used like ephy does Why need to check this? (Sorry for maybe stupid question but I realy don't know How can I select tab from keyboard in g.-t.?)
(In reply to comment #10) > Thanks for your reply! > > I have some question: > - add all the code to terminal-window.c, not part to terminal-tabs-menu > How can I accesses for private member of structure TerminalWindowPrivate from > other file? You can't, that's why the code should be in terminal-window.c. > - when popping up the menu with the keyboard, a menu positioning function needs > to be used like ephy does > Why need to check this? (Sorry for maybe stupid question but I realy don't know > How can I select tab from keyboard in g.-t.?) Click with the mouse on the tab label so that it gets the focus, then press Shift-F10.
Created attachment 114068 [details] [review] Add notebook popup menu(Corrected patch) Corrected all as described with one exception(pop up the menu with the keyboard is not enabled)
Thanks! I fixed some more issues and committed to svn trunk.
*** Bug 542588 has been marked as a duplicate of this bug. ***