After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 153409 - Windows press event is not sent to speech engine.
Windows press event is not sent to speech engine.
Status: RESOLVED FIXED
Product: gnopernicus
Classification: Deprecated
Component: keyboard&mouse
unspecified
Other Solaris
: Normal normal
: ---
Assigned To: Oana Serb
Oana Serb
AP2
Depends on:
Blocks:
 
 
Reported: 2004-09-22 11:01 UTC by Chandrashekhar. Korlahalli
Modified: 2005-03-07 13:58 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Proposed patch (1.80 KB, patch)
2005-02-15 16:13 UTC, Oana Serb
none Details | Review
A new patch (2.89 KB, patch)
2005-02-21 11:58 UTC, Oana Serb
needs-work Details | Review
A new patch (2.89 KB, patch)
2005-02-22 08:04 UTC, Oana Serb
accepted-commit_now Details | Review

Description Chandrashekhar. Korlahalli 2004-09-22 11:01:22 UTC
Installed cinnabar_18 on intel HP P4 machine.
Case:1
1. Run Gnopernicus,enabl accessibility,logout and login again.
2. Start gnopernicus,wait for the speech to start.
3. Check the checkbox, 'All modifiers' in gnopernicus speech preferences window.
4. Press the windows key.

Observation:The key is not read.
Case:2
1. Press the Num Lock Key
2. Now press any key modifier such as 'Ctrl','Shift', etc.

Observation: The key press events are not sent to speech engine.
 Expected: All key press events are required to be sent to speech engine.
Comment 1 Dana Ormenisan 2004-09-22 11:46:14 UTC
'Windows' key is not a modifier, so I think it shouldn't be presented by
gnopernicus if 'Say all modifiers' is checked. A compromise might be to present
this key with 'Say all navigation keys' checked.
Bill, Peter, others? Comments?
Comment 2 Calum Benson 2004-10-21 16:45:13 UTC
Apologies for spam-- ensuring Sun a11y team are cc'ed on all current a11y bugs.
 Filter on "SUN A11Y SPAM" to ignore.
Comment 3 Oana Serb 2005-02-15 16:13:36 UTC
Created attachment 37498 [details] [review]
Proposed patch

The "Window" key is added to be spoken
Comment 4 bill.haneman 2005-02-15 16:27:38 UTC
yes, the window key is actually a modifier on most systems.
While you're at it, why not present 'Hyper' as well?
Comment 5 remus draica 2005-02-17 12:01:44 UTC
Probably it should be also present in at-spi/atk list of modifiers since 'window
key is actually a modifier on most systems'. 
Comment 6 bill.haneman 2005-02-17 12:05:10 UTC
It is sent from at-spi, but as a MOD key.  There is no fixed mapping from
MODMASK bits to Hyper, you have to query XKB to get that information.

So you (gnopernicus) are getting notification from Hyper just as you are for
Super.  Please add the 'Hyper' logic to the patch so that 'Menu' gets spoken. 
Thanks!
Comment 7 Oana Serb 2005-02-21 09:33:04 UTC
Can you tell me, please, where is the location of 'Menu' key on the keyboard?
Because I'm not sure that 'Hyper' is the wanted key.
Comment 8 bill.haneman 2005-02-21 10:41:08 UTC
The location depends on the keyboard, of course ;-) and also on the keymap in
use.  I believe the keysyms of interest are XK_Hyper_L and XK_Hyper_R.

Note that there is anecdotal evidence that our XOrg keymaps may have these keys
'backwards' i.e. Hyper where Super should be and vice-versa.  So if you are
seeing wrong-looking info this may be the problem, please confirm if you see
this problem so we can file a bug against XOrg.
Comment 9 Oana Serb 2005-02-21 11:58:56 UTC
Created attachment 37743 [details] [review]
A new patch

The 'Hyper' key is added. I couldn't find this key on my keyboard, so I can't
tell you if there is a problem with 'Hyper' and 'Super' keys.
I also added the 'Menu' key.
Comment 10 bill.haneman 2005-02-21 17:32:43 UTC
Comment on attachment 37743 [details] [review]
A new patch

please change 'window' to 'Window', 'menu' to 'Menu', so that we can reuse
existing translated string.  Otherwise patch is OK.
Comment 11 Oana Serb 2005-02-22 08:04:13 UTC
Created attachment 37766 [details] [review]
A new patch

Changes: 'window' to 'Window' and 'menu' to 'Menu'.
Comment 12 remus draica 2005-02-28 14:18:58 UTC
Comment on attachment 37766 [details] [review]
A new patch


Patch committed to head.