After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 153023 - [PATCH] Preview image showed when changed workspace
[PATCH] Preview image showed when changed workspace
Status: RESOLVED OBSOLETE
Product: f-spot
Classification: Other
Component: Browsing
CVS
Other Linux
: Normal minor
: ---
Assigned To: F-spot maintainers
F-spot maintainers
Depends on:
Blocks:
 
 
Reported: 2004-09-18 20:21 UTC by Fernando Herrera
Modified: 2006-07-27 13:04 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Partial Solution (923 bytes, patch)
2005-01-27 23:37 UTC, Loz
committed Details | Review

Description Fernando Herrera 2004-09-18 20:21:09 UTC
I've F1 , F2 ... to switch to workspaces 1, 2...
When pressing ALT+F1 over f-spot, the workspace is changed and f-spot doesn't
get the release key event, so when I move my mouse in the new workspace it
supposed that it is over a picture and ALT is still pressed so it shows image
previews.
Comment 1 Loz 2005-01-27 23:13:15 UTC
I can reproduce this, using V and Win-F1, my window manager is metacity.

Some thoughts:

I'm pretty sure that workspaces depend on your window manager, so it is unlikely
that there will be a workspace switched event that is portable.

Our only other chance is to blame it on metacity.

I guess what we want to happen is that a workspace switch causes the previously
focused window to get the right key released events.

I'm sure that brings up all kinds of issues...
Comment 2 Loz 2005-01-27 23:37:10 UTC
Created attachment 36628 [details] [review]
Partial Solution

This stops the bleeding onto the second workspace.

It is still possible to get f-spot slightly in a twist:

Keep v pressed, switch workspace, release v, switch back. Now the preview popup
is up, and you can move around as if v were pressed for a bit.

Is this a bug in metacity?
Comment 3 Gabriel Burt 2005-10-13 05:45:48 UTC
I don't understand the bug or how to reproduce it.  Can one of you confirm this
is still an issue and explain it again to me?  Thanks.
Comment 4 Loz 2005-10-25 08:12:23 UTC
From memory, it was an issue with the way the preview function interacts with
multiple workspaces. 

At the time of writing, you could get a preview of a picture by hovering over it
and pressing v. If you switched workspaces, using a keyboard shortcut, while the
preview was up, then you could still see image previews on the second screen. I
think you could move the mouse around and get different previews, provided you
kept v pressed. The patch fixed that issue for me.

I'm not in a position to test this at the moment to see if it still a problem. 
Comment 5 Bengt Thuree 2006-02-18 05:35:24 UTC
I could reproduce this with F-Spot version 0.1.5

I set ALT-F3 as a shortcut command to go to Work Space 3.
I started F-Spot in work space 2.
Browser mode, press "v" and you get a preview picture.
While pressing "v", press ALT, and you get the File menu.
Hit Escape to break out from the File menu.
The preview image will still be visible, and now, when you move the mouse around you will see previews without having to press "v"
If you now press ALT-F3, and continue to move the mouse around, you will see the previews on the third work space.
Comment 6 Stephane Delcroix 2006-07-21 20:39:42 UTC
Bengt (comment #5): can you still reproduce this with f-spot 0.1.11 ??
Comment 7 Bengt Thuree 2006-07-27 13:04:08 UTC
Stephane: You are right... Can not reproduce it again.
Using CVS.

I will close this one as obsolete.
If it still a problem, lets re-open it again.