After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 152674 - Chart position inside graph should persist
Chart position inside graph should persist
Status: RESOLVED FIXED
Product: Gnumeric
Classification: Applications
Component: Charting
git master
Other Linux
: Normal normal
: ---
Assigned To: Jean Bréfort
Jody Goldberg
Depends on:
Blocks:
 
 
Reported: 2004-09-14 23:05 UTC by Adrian Custer
Modified: 2009-10-29 16:39 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch (9.44 KB, patch)
2005-02-09 20:37 UTC, Emmanuel Pacaud
needs-work Details | Review
updated patch (8.44 KB, patch)
2009-10-29 13:41 UTC, Jean Bréfort
none Details | Review
full patch (19.22 KB, patch)
2009-10-29 15:39 UTC, Jean Bréfort
none Details | Review

Description Adrian Custer 2004-09-14 23:05:30 UTC
When a graph has two charts, if their stacking is changed with the "order"
button the preview does not get updated, nor does the graph when the user clicks
okay. however if the user re-enters the guru the preview is updated and if the
user immediately leaves the guru, the order changes in the graph.


1) new gnumeric
2) launch the graph guru with the toolbar button
3) click on the forward button
4) click on the add button and add a second chart
=> top chart has a plot grid area, bottom one doesn't
5) click on the "Chart1" in the hiearchy area (top left)
6) click on the "order" button, then pick either "bottom" or "decrease"
==> the preview has not been updated
7) click on "ok"
8) place the graph on the sheet 
==> order is wrong
9) right click on graph, select properties from context menu
==> preview is correct
10) click ok
==> graph is now correct
Comment 1 Emmanuel Pacaud 2005-02-09 20:36:49 UTC
Here's a patch that makes chart position persistent. 

Since this bug was filled, reorder menu items were renamed "Push to
back", "Push backward", "Pull forward" and "Pull to front". So now,
changing chart position in the object tree should not change its
horizontal position in graph layout, just its Z order. Effect to reordering will
only be visible when there will be a UI for setting chart position.

The "good" behaviour seen by Adrian was actually a bug.
Comment 2 Emmanuel Pacaud 2005-02-09 20:37:27 UTC
Created attachment 37265 [details] [review]
patch
Comment 3 Jody Goldberg 2007-07-06 10:29:48 UTC
Doesn't look like this even made the transition to goffice.
Do we still need it ?
Comment 4 Andreas J. Guelzow 2008-09-20 03:40:37 UTC
Adrian's desription is still what is happening now. Clearly that is a bug and needs to be fixed.
Comment 5 Jean Bréfort 2008-11-11 12:00:43 UTC
I tested emmanuel's patch (with some needed changes, this is so old). Looks like it solves the issue, but I do not understand the automatic position mode logic. Seems that with the patch it is freezed for ever.
I think it would be more logic to have charts appear in the stack order when the position is automatic, not freezed or random order.
Comment 6 Andreas J. Guelzow 2009-08-05 22:20:13 UTC
Any news on this?
Comment 7 Jean Bréfort 2009-08-06 06:16:27 UTC
Nothing was done, so still there. Reassigning.
Comment 8 Jean Bréfort 2009-10-29 13:41:37 UTC
Created attachment 146501 [details] [review]
updated patch

What we need is a UI to set the charts position (row and column) when in auto mode. Btw, the framework supports multi-column disposition, but there is no user interface to make it happen.
Comment 9 Jean Bréfort 2009-10-29 15:39:16 UTC
Created attachment 146510 [details] [review]
full patch

Having chart specific code in gog-object.c is not a so good idea, imho, but fixes the issue for now.
Comment 10 Jean Bréfort 2009-10-29 16:39:47 UTC
Commited previous patch with a pair of modifications. Fixed. (5 years later!)