GNOME Bugzilla – Bug 152659
WARNING **: Owner of /tmp/orbit-<username> is not the current user
Last modified: 2006-10-22 14:06:45 UTC
1) Say you have a machine that runs gnome with a user named joe_user1. There will be a directory in /tmp called ./orbit-joe_user1. 2) If you create another account on the machine called joe_user (without the '1' suffix), when you start certain gtk programs (eg mozilla, grip) from the command line as joe_user, it will say WARNING **: Owner of /tmp/orbit-joe_user1 not the current user The program will start and run normally. Evidently the programs get confused when usernames have similar prefixes and different suffixes. Other people are apparently experiencing the same problem, see here: https://listman.redhat.com/archives/phoebe-list/2003-February/msg00688.html I am not 100% sure that gtk+ is the right section to post this bug in; if that is not the case please forward it to the correct section. Thank you.
We should use the UID instead of the user name for that file I think; that would save this problem (and some others) ever occuring.
The problem is from: orb/GIOP/giop.c: test_safe_socket_dir(const char *dirname) This function is used to scan a directory (from 'scan_socket_dir' in the same file). If there is both a 'marcus' and 'marc' (or any other combination, where the second username is a substring of the first), then the second user will get a: Owner of /tmp/orbit-marcus is not the current user
For the next gnome release we should switch to scanning /tmp/orbit-<UID>-* instead of the user-name; which would cause fewer problems. Patch welcome :-)
Consider we have two users user1 and user10. The ORBit directories created will be /tmp/orbit-user1 and /tmp/orbit-user10 respectively. In scan_socket_dir () we have a check as below: strncmp (dent, prefix, prefix_len); Now for user1, prefix will be 'orbit-user1'. The strncmp succeeds for 'orbit-user1' and 'orbit-user10' as well, but since user1 does not own 'orbit-user10' directory the warning message is displayed. Solution: Since user1 can have directories like /tmp/orbit-user1 or /tmp/orbit-user1-*, checking for /tmp/orbit-user1 first and then checking for /tmp/orbit-user1-* will fix this issue. Changing the strncmp () with the below will fix the issue: (strcmp (dent, prefix) && strncmp (dent, prefix_with_hyphen, prefix_len)) where, prefix_with_hyphen is 'orbit-user1-' Attaching a patch using this approach. Kindly note that if we use UIDs instead of username, we will still get the above warning due to strncmp (). Eg: We can users with UID 500 and 5000. Now for UID 500, the strncmp () will still succeed for UID 5000 and hence the bug. =====================================
Created attachment 72851 [details] [review] Patch to fix the bug
looks great to me - please do commit to HEAD. I still think that moving to a UID based solution is prolly better.
Michael: I can recreate a patch using UIDs but am not sure how UID based solution is a better approach. Even in case UIDs are used, we will still have to do both the above mentioned string comparisons (as done in the above attached patch). Kindly let me know if I am missing anything.
Michael: Attaching a modified patch to retain strncmp() instead of using strcmp(). Kindly note that this patch also doesn't use the UID approach.
Created attachment 73477 [details] [review] Modified patch to fix the issue
fine - I was happy with the original patch :-) please do commit. Brian - any chance you can deal with committing this if Manjunath has no CVS account ?
Michael: So should I go ahead and commit the second patch ? Kindly confirm.
go go go ! ;-)
Have checked in the patch to CVS HEAD on behalf of Manjunath. Thanks.
*** Bug 137784 has been marked as a duplicate of this bug. ***