GNOME Bugzilla – Bug 152620
Small icon (hIconSm member)
Last modified: 2006-10-29 00:11:28 UTC
The small icon is not initialized at RegisterGdkClass in gdkwindow-win32.c. It is better to initialize the small icon (hIconSm member).
Created attachment 31547 [details] [review] gdkwindow-win32.c's patch for gtk+-2.4.9
Wouldn't it be better to use a copy of the large icon as small icon if there is no small icon in the application's .exe's resources? Also, your patch loses the functionality that if the application .exe has no icon, the icon in the GDK DLL is used. Otherwise you are correct that it would be a good idea to try to extract a separate small icon.
updating patch status as per last comment. kazuki, can you update this patch?
After that, I evaded a problem by using gtk_window_set_default_icon_list. The programs that I made were settled, but generally the problem was left. I confirmed that this problem occurred equally on latest version (GTK+-2.10.6). I will participate in "CodeFest Kyoto 2006" tomorrow. I add it to one of my plans there. If I get a good idea, I am going to update patch.
Created attachment 74677 [details] [review] patch for gdkwindow-win32.c I updated a patch for latest version. If the application not has no icon, the icon in the GDK DLL is used. And if there is only an icon of either, it is used as both.
Thanks, applied to HEAD and gtk-2-10. 2006-10-29 Tor Lillqvist <tml@novell.com> * gdk/win32/gdkwindow-win32.c (RegisterGdkClass): Improve handling of the small icon of the window class. (#152620, Kazuki Iwamoto)