After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 152556 - null check is incorrect for %k handling
null check is incorrect for %k handling
Status: RESOLVED FIXED
Product: gnome-desktop
Classification: Core
Component: libgnome-desktop
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Desktop Maintainers
Desktop Maintainers
Depends on:
Blocks:
 
 
Reported: 2004-09-13 22:42 UTC by Brian Ryner
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (513 bytes, patch)
2004-09-13 22:43 UTC, Brian Ryner 		none Details | Review

Description Brian Ryner 2004-09-13 22:42:54 UTC 
libgnome-desktop appears to support %k which is replaced with the URI of the
.desktop file.  However, the null check for this case is backwards, so %k is
_not_ substituted when it should be, and if item->location is ever null, it will
crash.
Comment 1 Brian Ryner 2004-09-13 22:43:35 UTC 
Created attachment 31539 [details] [review]
patch
Comment 2 Mark McLoughlin 2004-09-14 07:33:57 UTC 
Thanks Brian - fix will be in 2.8.1:

2004-09-14  Mark McLoughlin  <mark@skynet.ie>

        Patch from Brian Ryner <bryner@brianryner.com> in bug #152556

        * gnome-desktop-item.c: (do_percent_subst): make %k work
        again.