After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 152289 - wavparse pushes buffers on unusable source pad
wavparse pushes buffers on unusable source pad
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins
git master
Other Linux
: Normal normal
: 0.8.5
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2004-09-10 01:14 UTC by Sebastien Cote
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed fix (939 bytes, patch)
2004-09-10 01:16 UTC, Sebastien Cote 		none Details | Review

Description Sebastien Cote 2004-09-10 01:14:45 UTC 
For some streams, gst_riff_create_audio_caps() returns NULL. In that case, the
wavparse adds a source pad without ever setting the explicit caps so the
negotiation never takes place. wavparse will then push buffers on its source pad
even if it isn't negotiated, generating a lot of warnings and the pipeline runs
as if it was successfull.

I guess if gst_riff_create_audio_caps() returns NULL, then wavparse shouldn't
add the source pad and it should generate an error.
Comment 1 Sebastien Cote 2004-09-10 01:16:24 UTC 
Created attachment 31459 [details] [review]
Proposed fix

If gst_riff_create_audio_caps() returns NULL, call GST_ELEMENT_ERROR() instead
of creating a pad without setting the caps.
Comment 2 Ronald Bultje 2004-10-01 12:39:15 UTC 
Applied, thanks.