GNOME Bugzilla – Bug 151850
not compliant .desktop file, + possible specs violation
Last modified: 2005-01-25 18:29:21 UTC
Distribution: Gentoo Base System version 1.5.3 Package: metacity Severity: minor Version: GNOME2.6.2 2.8.x Gnome-Distributor: Gentoo Linux Synopsis: not compliant .desktop file, + possible specs violation Bugzilla-Product: metacity Bugzilla-Component: general Bugzilla-Version: 2.8.x Description: Description of Problem: metacity.desktop file is not compliant with the .desktop file specification (0.9.4 on fd.o site) : - no "Encoding" key - no "Type" key - extended section not starting by X- The big question is : what program should be able to read this [Window Manager] section ? Actual section name violates the .desktop file specs If this section name is in the EWMH spec, one of those 2 specs should be changed and the program parsing this .desktop file should be aware of both the new and old section name (with and without X-) Steps to reproduce the problem: 1. installing metacity 2.8.4 2. desktop-file-validate /usr/share/gnome/wm-properties/metacity.desktop 3. see warnings Actual Results: /usr/share/gnome/wm-properties/metacity.desktop: error: file contains section Window Manager, extensions to the spec should use section names starting with "X-". /usr/share/gnome/wm-properties/metacity.desktop: error: required key "Encoding" not found /usr/share/gnome/wm-properties/metacity.desktop: error: required key "Type" not found Expected Results: no warning at all How often does this happen? every time Additional Information: desktop-file-validate from desktop-file-utils 0.7 (fd.o site) last thing. shouldn't those extension be moved under the new section and prefix removed ? # name of loadable control center module X-GNOME-WMSettingsModule=metacity # name we put on the WM spec check window X-GNOME-WMName=Metacity # back compat only X-GnomeWMSettingsLibrary=metacity ------- Bug moved to this database by unknown@bugzilla.gnome.org 2004-09-04 15:07 ------- Unknown platform unknown. Setting to default platform "Other". Unknown milestone "unknown" in product "metacity". Setting to default milestone for this product, '---' Setting to default status "UNCONFIRMED". Setting qa contact to the default for this product. This bug either had no qa contact or an invalid one.
Created attachment 31262 [details] [review] patch to src/metacity.desktop.in perhaps the last chunk ([Window Manager] => [X-Window Manager]) should not be applied as it could break the app supposed to parse this kind of .desktop file
This .desktop file is in a GNOME-specific directory, and is just used internally by GNOME control center; so complying with the fd.org spec designed for menus is not really a big issue. Changing the section name will indeed break the control center so should avoid that. Adding Encoding seems sensible; adding Type I guess is OK, but you'd have to test that nothing breaks in control-center
so, to sum up, it's a gnome specific WM configuration file ?! ok not to have to comply to the .desktop file specs in this case. but as it is a desktop specific config file, why using a .desktop suffix and .desktop like syntax at all ? (using a .desktop parser function to not rewrite one more config file parser ?) anyway, as KDE or other desktop env would never see that file, you can close this bug as NOTABUG or whatever.
Right, this is something that dates from GNOME 1.x. AFAIK it's only used by the GNOME control center. Fixing Encoding couldn't hurt, though.
Since Havoc said fixing the Encoding couldn't hurt, I went ahead and committed that part of the patch: 2005-01-25 Elijah Newren <newren@math.utah.edu> Patch from Stephane LOEUILLET in bug #151850. * src/metacity.desktop.in: specify encoding As Stephane suggests, I'm going to go ahead and close this as NOTABUG. Thanks for the encoding fix, Stephane.