GNOME Bugzilla – Bug 151834
Mixer icon in "Add to panel" window is broken
Last modified: 2004-12-22 21:47:04 UTC
The icon that should appear together the mixer applet in the "Add to panel" window is broken. In fact, it does not appear. To reproduce: right click on panel, click "Add to panel", search the entry for "Volume control" and notice that it has no associated icon. The problem comes because icons are installed in a subdirectory of pixmaps, i.e., pixmaps/mixer. However, the GNOME_MixerApplet.server.in.in file, which contains a reference to the icon, only says 'gnome-mixer-applet.png', so the file is searched inside pixmaps only. That file name should be prefixed with a 'mixer/' string. Note that all other code of the mixer applet adds the 'mixer/' prefix to icons, so I expect this to be the appropiate solution. To verify, just run "grep png *.c" inside the mixer subdirectory.
Created attachment 31257 [details] [review] Sample patch
Aaa haa, I knew there was a reason I had not noticed the mixer on my list the other day. It's amazing what you can fail to notice. Thanks for pointing this one out.
Created attachment 31321 [details] [review] install the mixer icon in the 'correct' place Mark McLoughlin suggested that the icon was being installed in the wrong location, and this prevented the icon from being themeable. He had this to say: I'd suggest a patch like the one attached - that will allow people to add icons to their icon theme and it will override the on supplied by the mixer. (Note, the icon in the theme won't override the window icon and such because the mixer code doesn't use the icon theme)
This is fixed in CVS. Please test.