After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 151824 - Build broken under NetBSD because of battstat
Build broken under NetBSD because of battstat
Status: RESOLVED FIXED
Product: gnome-applets
Classification: Other
Component: battery
git master
Other other
: Urgent major
: ---
Assigned To: gnome-applets Maintainers
gnome-applets Maintainers
Depends on:
Blocks:
 
 
Reported: 2004-09-04 14:09 UTC by Julio Merino
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: 2.8.x
GNOME version: 2.7/2.8


Attachments
Sample patch (1.01 KB, patch)
2004-09-04 14:10 UTC, Julio Merino
none Details | Review

Description Julio Merino 2004-09-04 14:09:27 UTC
The battstat applet is broken under NetBSD (and probably under _all_ other BSDs)
because some of the changes done recently in the development branch of
gnome-applets.  All the problems are found in the battstat_applet.c file.

First of all, it includes acpi-linux.h.  Obviously, this is to be used _only_
under Linux; the code does well in not using any of the functions defined in it
when building outside Linux, but the header is included unconditionally.  So it
has to be included only under Linux.

Second, there are several problems caused by a typedef.  I've tried several
different combinations, but never got a correct solution, so I ended up
switching it to a #define.

At last, the code tries to use a member of the apm_power_info structure that
does not exist.  It seems to be a typo.
Comment 1 Julio Merino 2004-09-04 14:10:04 UTC
Created attachment 31254 [details] [review]
Sample patch

Sample patch that fixes all problems described.
Comment 2 Danielle Madeley 2004-09-04 14:27:08 UTC
That patch looks fine. The use of a typedef was probably gratuitous and
unrequired. I was waiting until a BSD build problem turned up.

I've submitted this to the release team to request deep freeze breakage.
Comment 3 Danielle Madeley 2004-09-06 08:10:53 UTC
Ok, this is fixed in CVS. Please, PLEASE test this before the GNOME 2.8 release.
Thanks.