GNOME Bugzilla – Bug 151824
Build broken under NetBSD because of battstat
Last modified: 2004-12-22 21:47:04 UTC
The battstat applet is broken under NetBSD (and probably under _all_ other BSDs) because some of the changes done recently in the development branch of gnome-applets. All the problems are found in the battstat_applet.c file. First of all, it includes acpi-linux.h. Obviously, this is to be used _only_ under Linux; the code does well in not using any of the functions defined in it when building outside Linux, but the header is included unconditionally. So it has to be included only under Linux. Second, there are several problems caused by a typedef. I've tried several different combinations, but never got a correct solution, so I ended up switching it to a #define. At last, the code tries to use a member of the apm_power_info structure that does not exist. It seems to be a typo.
Created attachment 31254 [details] [review] Sample patch Sample patch that fixes all problems described.
That patch looks fine. The use of a typedef was probably gratuitous and unrequired. I was waiting until a BSD build problem turned up. I've submitted this to the release team to request deep freeze breakage.
Ok, this is fixed in CVS. Please, PLEASE test this before the GNOME 2.8 release. Thanks.