GNOME Bugzilla – Bug 151573
[PATCH] Fix FreeBSD support in gnome-cd
Last modified: 2004-12-22 21:47:04 UTC
This patch covers two FreeBSD issues in gnome-cd. One has been present for a while. The track progress slider does not move in FreeBSD. The patch to fix this was adapted from linux-cdrom.c The second problem was introduced in gnome-media-2.7.92. The new gst-cdparanoia-cdrom.c is heavily Linux-specific, but built by default on all platforms. The first clue that it wouldn't work on Solaris or *BSD should have been the fact that it includes linux/cdrom.h. In any event, I have added FreeBSD support to that backend (though it may not be needed).
Ah, one other issue. FreeBSD does define socklen_t, but does not define __socklen_t_defined. A better fix would be to add a configure check that includes sys/types.h and sys/socket.h, then checks for socklen_t. In the meanwhile, I've just added a check for __FreeBSD__. Note: this probably affects other BSDs as well, but unfortunately, I don't have the machines with which to test.
Created attachment 31168 [details] [review] Fix FreeBSD support in gnome-media
Created attachment 31293 [details] [review] Patch with FreeBSD and NetBSD support This patch is an extension to the patch posted by Marcus. It adds support for NetBSD, and hopefully for OpenBSD too. I hope to not have broken anything else. BTW, thanks Marcus for the original patch; it made my job easier ;)
I hate that cdparanoia part. No offense to you guys, but we (Thomas and me) are having second thoughts on using that in the first place. Give us some time to think that over. :). I'll make sure that the bsd-cdrom parts make it into the 2.8.0 release. It'll probably become the default, just like in 2.6.x.
Applied.
*** Bug 145371 has been marked as a duplicate of this bug. ***