GNOME Bugzilla – Bug 151420
[PATCH] matroska-demux.c build failure on x86_64
Last modified: 2004-12-22 21:47:04 UTC
Again, another jhbuild -Werror which turns a warning on x86_64 into a compilation error. This time: gcc -DHAVE_CONFIG_H -I. -I. -I../.. -I../../gst-libs -I../../gst-libs -pthread -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -I/home/nathanr/bin/gnome2-cvs/include/glib-2.0 -I/home/nathanr/bin/gnome2-cvs/lib64/glib-2.0/include -I/home/nathanr/bin/gnome2-cvs/include/libxml2 -I/home/nathanr/bin/gnome2-cvs/include/gstreamer-0.8 -DGST_DISABLE_DEPRECATED -Wall -Werror -g -O2 -MT libgstmatroska_la-matroska-demux.lo -MD -MP -MF .deps/libgstmatroska_la-matroska-demux.Tpo -c matroska-demux.c -fPIC -DPIC -o .libs/libgstmatroska_la-matroska-demux.o matroska-demux.c: In function `gst_matroska_demux_parse_contents': matroska-demux.c:2179: warning: long long unsigned int format, guint64 arg (arg 6) make[3]: *** [libgstmatroska_la-matroska-demux.lo] Error 1 make[3]: Leaving directory `/home/nathanr/download/gnome-cvs/gst-plugins/gst/matroska' make[2]: *** [all-recursive] Error 1 make[2]: Leaving directory `/home/nathanr/download/gnome-cvs/gst-plugins/gst' make[1]: *** [all-recursive] Error 1 make[1]: Leaving directory `/home/nathanr/download/gnome-cvs/gst-plugins' make: *** [all] Error 2 *** error during stage build of gst-plugins: could not build module *** [70/91] is fixed by: --- matroska-demux.c.~1.32.~ 2004-08-26 00:41:11.000000000 +1000 +++ matroska-demux.c 2004-08-30 22:50:34.467376312 +1000 @@ -2177,7 +2177,7 @@ } if (id != seek_id) { g_warning ("We looked for ID=0x%x but got ID=0x%x (pos=%llu)", - seek_id, id, seek_pos + demux->segment_start); + seek_id, id, (long long unsigned int) (seek_pos + demux->segment_start)); goto finish; }
I'd rather not cast the value but use the G_GUINT64_FORMAT macros provided by glib for the string type.
Created attachment 31099 [details] [review] Correct patch
Fixed.