After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 151392 - gdk_gl_pixmap_make_current broken
gdk_gl_pixmap_make_current broken
Status: RESOLVED FIXED
Product: gtkglarea
Classification: Other
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: C.J. Collier
Xavier Ordoquy
Depends on:
Blocks:
 
 
Reported: 2004-08-30 03:53 UTC by Glynn Clements
Modified: 2006-12-03 01:36 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Glynn Clements 2004-08-30 03:53:04 UTC
gdk_gl_pixmap_make_current() validates the "context" argument using
GDK_IS_GL_PIXMAP(), when it should be using GDK_IS_GL_CONTEXT().
Consequently, the function always fails.

Fix:

Index: gtkgl/gdkgl.c
===================================================================
RCS file: /cvs/gnome/gtkglarea/gtkgl/gdkgl.c,v
retrieving revision 1.12
diff -u -r1.12 gdkgl.c
--- gtkgl/gdkgl.c	9 Jun 2002 16:22:36 -0000	1.12
+++ gtkgl/gdkgl.c	29 Aug 2004 03:56:20 -0000
@@ -395,7 +395,7 @@
   GLXContext glxcontext;
 
   g_return_val_if_fail(GDK_IS_GL_PIXMAP(glpixmap), FALSE);
-  g_return_val_if_fail(GDK_IS_GL_PIXMAP(context), FALSE);
+  g_return_val_if_fail(GDK_IS_GL_CONTEXT(context), FALSE);
 
   dpy        = context->xdisplay;
   glxpixmap  = glpixmap->glxpixmap;
Comment 1 C.J. Collier 2006-12-03 01:24:25 UTC
Let me apply that or verify that it has already been applied...
Comment 2 C.J. Collier 2006-12-03 01:29:51 UTC
It was not applied.  I applied it.  Please verify fix now.