GNOME Bugzilla – Bug 151147
New Toolbox Icons
Last modified: 2006-04-08 10:41:41 UTC
The largely black and white icons of the dia toolbox don't mix very well with the current GNOME stock tools. The attached icons have been submitted to the dia mailing list. I supprt Alan's statement to take over the stock icons from the GIMP for Modify, Zoom, Scroll, and Text.
Created attachment 30987 [details] New icons for the dia toolbox.
Lars, Hans: I'm not sure what's the best way to switch from XPM to PNG for these icons (I think it's a good chance to do this at this stage). If you give one example (or some hints), I can repeat this for the other icons.
Adding PATCH keyword. Hints I can give: Look in app/pixmaps, there's a mix of both. See Makefile.am for what is required to do. However, there's some programming to do, as the ToolButton struct assumes XPM. Not as trivial as it ought to be:( I would prefer to get rid of all XPM eventually.
Created attachment 30992 [details] Modification of some icons I have add two polygone icons, one just with a little difference of the first and the second with one more side (can be change to fit as you want) Also do a change to the ellispe icons and add the center of the ellipse tools. I can put the xcf files too if you want and also change to xpm file type but with this you lose some transparency effects.
Should we introduce GtkIconFactory?
I'm working on a solution for the tools like arc, ellipse, etc.
Created attachment 31061 [details] .tar.bz2 file containing small changes * moved the files to app/pixmaps * renamed some files * removed some files that could be replaced by GNOME/GIMP stock icons
Created attachment 31062 [details] new_dia_icons4.tar.bz2 Changed the "theme" once more, using existing GNOME and GIMP stock icons as much as possible.
Created attachment 31063 [details] [review] dia_new_icons.diff The diff against the current CVS. Use together with the latest dia_icons4.tar.bz2 XPMS still have to be removed from the build process (will do this after the patch has been accepted)
The patch seems to mess up Drag'n'Drop icons for some shapes: (lt-dia:7973): Gtk-CRITICAL **: file gtkdnd.c: line 2127 (gtk_drag_source_set_icon_pixbuf): assertion `GDK_IS_PIXBUF (pixbuf)' failed
Created attachment 31095 [details] [review] dia_new_icons2.diff Fixes the mentioned problems.
Created attachment 31124 [details] new-dia-icons-4.2-tar.bz2 I have done some change to the icons to fit the style of the tools in dia. Also change the zoom tools to use the same as gimp 2.0. I don't have found a cursor gnome stock icons for the modify icons. Tell me what you think about this changes.
Why not share icons with Inkscape and The Gimp? Then we would have consistent UIs for these apps.
Is there any particular reason why a patch like this should not be applied straight away?
On my part, just been too busy, only now have time to go through almost 200 bug report mails. Since it is marked PATCH, I will get back to it before the next release.
On my part, I just haven't noticed it ;) But now that I have : Hi Steffen, one thing I dislike on your patch is the use of even more files floating around to make Dia work. I also expect this be a performance issue. As already noted on an other bug gdk-pixbuf-source should be used to include the files and GtkIconFactory be used to handle them. See: http://cvs.gnome.org/viewcvs/gimp/libgimpwidgets/gimpstock.c for a very elaborated example. app/maklefile.msc alread has the code to turn PNG into a C header file.
I'm fairly sure the performance difference is small, PNG files are very small and csourcing them blows them up by a factor 7, which is then included in the binary. Even if the opening/closing of the PNG files is faster, it's still I'm sure much less than the plugin loading, which currently takes most of the startup time. The issue of having more files floating around is more important. Already now, app/run_dia.sh doesn't take the pngs out of the source dir, so avoiding that would be nice. It does appear that 8-bit alpha is preserved by gdk-pixbuf-csource, and since our loading is centralized, it ought to be easy to do (ought to:).
Comment on attachment 31063 [details] [review] dia_new_icons.diff obsoled by the following version
Comment on attachment 31095 [details] [review] dia_new_icons2.diff as menitioned in the comments above IMO the patch needs quite some work. Marking as such.
Steffen, sorry to not apply your patch and get pretty icons, but we've just gotten rid of run-time loading of images into code (still OK for sheets, of course), so this really needs to be done with the gdk-pixbuf-csource'd versions. See how to use them in lib/widgets.c, in dia_toggle_button_new_with_icons(). Marking as NEEDINFO to get off my list while waiting for a working version.
I think this is fixed in the CVS.
Closing. Steffen, feel free to close your bug reports yourself ;-)