After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 151119 - Added Phonebook
Added Phonebook
Status: RESOLVED FIXED
Product: gnome-phone-manager
Classification: Other
Component: general
unspecified
Other Linux
: Normal enhancement
: ---
Assigned To: Edd Dumbill
Edd Dumbill
Depends on:
Blocks: 307404
 
 
Reported: 2004-08-26 11:51 UTC by Patrick Steiner
Modified: 2005-06-13 09:55 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
phonemgr phonebook patch (4.09 KB, text/plain)
2004-08-26 11:52 UTC, Patrick Steiner
  Details
this is the right one (4.09 KB, application/x-gzip)
2004-08-26 11:54 UTC, Patrick Steiner
  Details
gnome-phone-manager-phone-entry.patch (59.41 KB, patch)
2005-06-12 15:38 UTC, Bastien Nocera
committed Details | Review

Description Patrick Steiner 2004-08-26 11:51:22 UTC
i have added ah little phonebook to the current gnome-phone-manager cvs-tree. it
isnt ready yet. but have a look.

see patch file for the diffs
Comment 1 Patrick Steiner 2004-08-26 11:52:37 UTC
Created attachment 30965 [details]
phonemgr phonebook patch

this is the patch file
Comment 2 Patrick Steiner 2004-08-26 11:54:30 UTC
Created attachment 30966 [details]
this is the right one
Comment 3 Patrick Steiner 2004-08-26 11:57:09 UTC
im not able to upload the tar.gz file you can download from my homepage.

http://sickpeople.wmc-allstars.com/law/files/phonemgr-patch.tar.gz

Comment 4 Bastien Nocera 2005-03-31 16:48:19 UTC
Wouldn't it be better to use the evolution-data-server to get a list of people
with their mobile phone numbers directly? This should be fairly easy with evo
2.2's "name selector completion widgetry".
Comment 5 Edd Dumbill 2005-04-07 10:09:47 UTC
Ross was doing some work on this recently too, with EDS.

Using Evo's widgets would be preferable.
Comment 6 Bastien Nocera 2005-06-12 15:38:38 UTC
Created attachment 47653 [details] [review]
gnome-phone-manager-phone-entry.patch

- Add EPhoneEntry and EContactEntry from contact-lookup-applet
- Add update-from-egg.sh to update the files automatically
- Use an EPhoneEntry instead of a GtkEntry
- Use e_phone_entry_get_number instead of gtk_entry_get_text
- Check for libebook in configure

(Note that this is untested as libgsm doesn't work with my phone)
Comment 7 Bastien Nocera 2005-06-12 15:39:13 UTC
Add Ross to the CC: so he can double-check the changes.
Comment 8 Bastien Nocera 2005-06-13 09:55:35 UTC
2005-06-13  Bastien Nocera  <hadess@hadess.net>

        * configure.in:
        * src/Makefile.am:
        * src/e-contact-entry.c:
        * src/e-contact-entry.h:
        * src/e-phone-entry.c:
        * src/e-phone-entry.h:
        * src/test-entry.c:
        * src/ui.c: (set_send_sensitivity), (phone_number_changed),
        (send_message), (create_send_dialog):
        * src/update-from-egg.sh:
        * ui/phonemgr.glade:
        * ui/phonemgr.gladep:
        * ui/strings.c:

        Check for libebook in configure
        Add EContactEntry from contact-lookup-applet with script to update
        the files
        Add new EPhoneEntry widget, which checks for mobile phone numbers
        in Evolution's addressbook
        Make gnome-phone-manager use EPhoneEntry rather than a plain GtkEntry
        Remove unused files
        (Closes: #151119)